From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-riscv@nongnu.org,
qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
qemu-ppc@nongnu.org, "Daniel P.Berrangé" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
qemu-s390x@nongnu.org
Subject: Re: [PATCH v2 4/8] hw/boards: Remove all invalid uses of auto_create_sdcard=true
Date: Thu, 6 Feb 2025 11:12:46 +0100 [thread overview]
Message-ID: <34235ce5-9f6c-4968-a8c1-ab868389e9cf@linaro.org> (raw)
In-Reply-To: <87a5b07u1d.fsf@pond.sub.org>
On 5/2/25 08:03, Markus Armbruster wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>
>> MachineClass::auto_create_sdcard is only useful to automatically
>> create a SD card, attach a IF_SD block drive to it and plug the
>> card onto a SD bus. Only the ARM and RISCV targets use such
>> feature:
>>
>> $ git grep -wl IF_SD hw | cut -d/ -f-2 | sort -u
>> hw/arm
>> hw/riscv
>> $
>>
>> Remove all other uses.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>
> Impact?
>
> As far as I can tell, this stops creation of the if=sd default drive
> these machines don't actually use. Correct?
>
Yes, since these machines don't expose a SD-bus, the drive can
not be attached and always triggers the same error:
$ qemu-system-hppa -sd /bin/sh
qemu-system-hppa: -sd /bin/sh: machine type does not support
if=sd,bus=0,unit=0
next prev parent reply other threads:[~2025-02-06 10:13 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 18:07 [PATCH v2 0/8] hw/boards: Try to make sense of MachineClass::no_sdcard flag Philippe Mathieu-Daudé
2025-02-04 18:07 ` [PATCH v2 1/8] hw/boards: Convert no_sdcard flag to OnOffAuto tri-state Philippe Mathieu-Daudé
2025-02-04 18:07 ` [PATCH v2 2/8] hw/boards: Explicit no_sdcard=false as ON_OFF_AUTO_OFF Philippe Mathieu-Daudé
2025-02-04 18:16 ` Thomas Huth
2025-02-04 18:07 ` [PATCH v2 3/8] hw/boards: Rename no_sdcard -> auto_create_sdcard Philippe Mathieu-Daudé
2025-02-04 18:19 ` Thomas Huth
2025-02-04 18:24 ` Philippe Mathieu-Daudé
2025-02-04 18:07 ` [PATCH v2 4/8] hw/boards: Remove all invalid uses of auto_create_sdcard=true Philippe Mathieu-Daudé
2025-02-04 18:26 ` Thomas Huth
2025-02-05 7:03 ` Markus Armbruster
2025-02-06 10:12 ` Philippe Mathieu-Daudé [this message]
2025-02-06 12:56 ` BALATON Zoltan
2025-02-06 13:14 ` Philippe Mathieu-Daudé
2025-02-06 13:44 ` BALATON Zoltan
2025-02-07 12:49 ` Markus Armbruster
2025-02-10 14:03 ` Philippe Mathieu-Daudé
2025-02-10 14:41 ` Markus Armbruster
2025-02-04 18:07 ` [PATCH v2 5/8] hw/ppc/e500: Remove empty ppce500_machine_class_init() Philippe Mathieu-Daudé
2025-02-04 18:12 ` Philippe Mathieu-Daudé
2025-02-04 18:27 ` Thomas Huth
2025-02-04 18:07 ` [PATCH v2 6/8] hw/arm: Remove all invalid uses of auto_create_sdcard=true Philippe Mathieu-Daudé
2025-02-04 18:44 ` Thomas Huth
2025-02-04 19:10 ` Philippe Mathieu-Daudé
2025-02-04 18:07 ` [PATCH v2 7/8] hw/riscv: " Philippe Mathieu-Daudé
2025-02-04 18:46 ` Thomas Huth
2025-02-04 18:07 ` [PATCH v2 8/8] hw/boards: Ensure machine setting auto_create_sdcard expose a SD Bus Philippe Mathieu-Daudé
2025-02-04 18:10 ` [PATCH v2 0/8] hw/boards: Try to make sense of MachineClass::no_sdcard flag Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34235ce5-9f6c-4968-a8c1-ab868389e9cf@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).