[PATCH] vhost-user: Use correct macro name TARGET

qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] vhost-user: Use correct macro name TARGET_PPC64
@ 2022-05-03 18:01 Murilo Opsfelder Araujo
  2022-05-03 18:16 ` Daniel Henrique Barboza
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Murilo Opsfelder Araujo @ 2022-05-03 18:01 UTC (permalink / raw)
  To: qemu-devel
  Cc: Michael S. Tsirkin, qemu-ppc, mopsfelder, Murilo Opsfelder Araujo,
	Fabiano Rosas, Raphael Norwitz, Peter Turschmid

The correct name of the macro is TARGET_PPC64.

Fixes: 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
Reported-by: Fabiano Rosas <farosas@linux.ibm.com>
Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
Cc: Raphael Norwitz <raphael.norwitz@nutanix.com>
Cc: Peter Turschmid <peter.turschm@nutanix.com>
---
 hw/virtio/vhost-user.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index 9c4f84f35f..e356c72c81 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -51,7 +51,7 @@
 #include "hw/acpi/acpi.h"
 #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
 
-#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
+#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
 #include "hw/ppc/spapr.h"
 #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS
 
-- 
2.35.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] vhost-user: Use correct macro name TARGET_PPC64
  2022-05-03 18:01 [PATCH] vhost-user: Use correct macro name TARGET_PPC64 Murilo Opsfelder Araujo
@ 2022-05-03 18:16 ` Daniel Henrique Barboza
  2022-05-04 20:42 ` Daniel Henrique Barboza
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Daniel Henrique Barboza @ 2022-05-03 18:16 UTC (permalink / raw)
  To: Murilo Opsfelder Araujo, qemu-devel
  Cc: Michael S. Tsirkin, qemu-ppc, mopsfelder, Fabiano Rosas,
	Raphael Norwitz, Peter Turschmid



On 5/3/22 15:01, Murilo Opsfelder Araujo wrote:
> The correct name of the macro is TARGET_PPC64.
> 
> Fixes: 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
> Reported-by: Fabiano Rosas <farosas@linux.ibm.com>
> Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
> Cc: Raphael Norwitz <raphael.norwitz@nutanix.com>
> Cc: Peter Turschmid <peter.turschm@nutanix.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>


>   hw/virtio/vhost-user.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 9c4f84f35f..e356c72c81 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -51,7 +51,7 @@
>   #include "hw/acpi/acpi.h"
>   #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
>   
> -#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
> +#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
>   #include "hw/ppc/spapr.h"
>   #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS
>   


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] vhost-user: Use correct macro name TARGET_PPC64
  2022-05-03 18:01 [PATCH] vhost-user: Use correct macro name TARGET_PPC64 Murilo Opsfelder Araujo
  2022-05-03 18:16 ` Daniel Henrique Barboza
@ 2022-05-04 20:42 ` Daniel Henrique Barboza
  2022-05-04 20:59 ` Michael S. Tsirkin
  2022-05-04 23:44 ` [PATCH] vhost-user: Use correct macro name TARGET_PPC64g Raphael Norwitz
  3 siblings, 0 replies; 6+ messages in thread
From: Daniel Henrique Barboza @ 2022-05-04 20:42 UTC (permalink / raw)
  To: Murilo Opsfelder Araujo, qemu-devel
  Cc: Michael S. Tsirkin, qemu-ppc, mopsfelder, Fabiano Rosas,
	Raphael Norwitz, Peter Turschmid

Michael,

I'll send a PR in the next few days. This change seems trivial enough to me
to push via the PPC64 tree.

Let me know if you're ok with that or if you want to pick it via the vhost tree.



Thanks,


Daniel


On 5/3/22 15:01, Murilo Opsfelder Araujo wrote:
> The correct name of the macro is TARGET_PPC64.
> 
> Fixes: 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
> Reported-by: Fabiano Rosas <farosas@linux.ibm.com>
> Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
> Cc: Raphael Norwitz <raphael.norwitz@nutanix.com>
> Cc: Peter Turschmid <peter.turschm@nutanix.com>
> ---
>   hw/virtio/vhost-user.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 9c4f84f35f..e356c72c81 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -51,7 +51,7 @@
>   #include "hw/acpi/acpi.h"
>   #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
>   
> -#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
> +#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
>   #include "hw/ppc/spapr.h"
>   #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS
>   


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] vhost-user: Use correct macro name TARGET_PPC64
  2022-05-03 18:01 [PATCH] vhost-user: Use correct macro name TARGET_PPC64 Murilo Opsfelder Araujo
  2022-05-03 18:16 ` Daniel Henrique Barboza
  2022-05-04 20:42 ` Daniel Henrique Barboza
@ 2022-05-04 20:59 ` Michael S. Tsirkin
  2022-05-04 21:45   ` Daniel Henrique Barboza
  2022-05-04 23:44 ` [PATCH] vhost-user: Use correct macro name TARGET_PPC64g Raphael Norwitz
  3 siblings, 1 reply; 6+ messages in thread
From: Michael S. Tsirkin @ 2022-05-04 20:59 UTC (permalink / raw)
  To: Murilo Opsfelder Araujo
  Cc: qemu-devel, qemu-ppc, mopsfelder, Fabiano Rosas, Raphael Norwitz,
	Peter Turschmid

On Tue, May 03, 2022 at 03:01:08PM -0300, Murilo Opsfelder Araujo wrote:
> The correct name of the macro is TARGET_PPC64.
> 
> Fixes: 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
> Reported-by: Fabiano Rosas <farosas@linux.ibm.com>
> Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
> Cc: Raphael Norwitz <raphael.norwitz@nutanix.com>
> Cc: Peter Turschmid <peter.turschm@nutanix.com>

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

ok to merge through the ppc tree

> ---
>  hw/virtio/vhost-user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 9c4f84f35f..e356c72c81 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -51,7 +51,7 @@
>  #include "hw/acpi/acpi.h"
>  #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
>  
> -#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
> +#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
>  #include "hw/ppc/spapr.h"
>  #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS
>  
> -- 
> 2.35.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] vhost-user: Use correct macro name TARGET_PPC64
  2022-05-04 20:59 ` Michael S. Tsirkin
@ 2022-05-04 21:45   ` Daniel Henrique Barboza
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Henrique Barboza @ 2022-05-04 21:45 UTC (permalink / raw)
  To: Michael S. Tsirkin, Murilo Opsfelder Araujo
  Cc: qemu-devel, qemu-ppc, mopsfelder, Fabiano Rosas, Raphael Norwitz,
	Peter Turschmid



On 5/4/22 17:59, Michael S. Tsirkin wrote:
> On Tue, May 03, 2022 at 03:01:08PM -0300, Murilo Opsfelder Araujo wrote:
>> The correct name of the macro is TARGET_PPC64.
>>
>> Fixes: 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
>> Reported-by: Fabiano Rosas <farosas@linux.ibm.com>
>> Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
>> Cc: Raphael Norwitz <raphael.norwitz@nutanix.com>
>> Cc: Peter Turschmid <peter.turschm@nutanix.com>
> 
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> 
> ok to merge through the ppc tree

Thanks for the r-b.  Queued in gitlab.com/danielhb/qemu/tree/ppc-next.



Daniel

> 
>> ---
>>   hw/virtio/vhost-user.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
>> index 9c4f84f35f..e356c72c81 100644
>> --- a/hw/virtio/vhost-user.c
>> +++ b/hw/virtio/vhost-user.c
>> @@ -51,7 +51,7 @@
>>   #include "hw/acpi/acpi.h"
>>   #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
>>   
>> -#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
>> +#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
>>   #include "hw/ppc/spapr.h"
>>   #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS
>>   
>> -- 
>> 2.35.1
> 
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] vhost-user: Use correct macro name TARGET_PPC64g
  2022-05-03 18:01 [PATCH] vhost-user: Use correct macro name TARGET_PPC64 Murilo Opsfelder Araujo
                   ` (2 preceding siblings ...)
  2022-05-04 20:59 ` Michael S. Tsirkin
@ 2022-05-04 23:44 ` Raphael Norwitz
  3 siblings, 0 replies; 6+ messages in thread
From: Raphael Norwitz @ 2022-05-04 23:44 UTC (permalink / raw)
  To: Murilo Opsfelder Araujo
  Cc: qemu-devel@nongnu.org, Michael S. Tsirkin, qemu-ppc@nongnu.org,
	mopsfelder@gmail.com, Fabiano Rosas, Raphael Norwitz,
	Peter Turschmid

On Tue, May 03, 2022 at 03:01:08PM -0300, Murilo Opsfelder Araujo wrote:
> The correct name of the macro is TARGET_PPC64.
> 
> Fixes: 27598393a232 ("Lift max memory slots limit imposed by vhost-user")
> Reported-by: Fabiano Rosas <farosas@linux.ibm.com>
> Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
> Cc: Raphael Norwitz <raphael.norwitz@nutanix.com>
> Cc: Peter Turschmid <peter.turschm@nutanix.com>

Reviewed-by: Raphael Norwitz <raphael.norwitz@nutanix.com>

> ---
>  hw/virtio/vhost-user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 9c4f84f35f..e356c72c81 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -51,7 +51,7 @@
>  #include "hw/acpi/acpi.h"
>  #define VHOST_USER_MAX_RAM_SLOTS ACPI_MAX_RAM_SLOTS
>  
> -#elif defined(TARGET_PPC) || defined(TARGET_PPC_64)
> +#elif defined(TARGET_PPC) || defined(TARGET_PPC64)
>  #include "hw/ppc/spapr.h"
>  #define VHOST_USER_MAX_RAM_SLOTS SPAPR_MAX_RAM_SLOTS
>  
> -- 
> 2.35.1
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-05-04 23:46 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-03 18:01 [PATCH] vhost-user: Use correct macro name TARGET_PPC64 Murilo Opsfelder Araujo
2022-05-03 18:16 ` Daniel Henrique Barboza
2022-05-04 20:42 ` Daniel Henrique Barboza
2022-05-04 20:59 ` Michael S. Tsirkin
2022-05-04 21:45   ` Daniel Henrique Barboza
2022-05-04 23:44 ` [PATCH] vhost-user: Use correct macro name TARGET_PPC64g Raphael Norwitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).