From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1689C433F5 for ; Tue, 14 Sep 2021 16:20:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5699E60F70 for ; Tue, 14 Sep 2021 16:20:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5699E60F70 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:38330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQBA7-0004fB-GE for qemu-devel@archiver.kernel.org; Tue, 14 Sep 2021 12:20:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48504) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQAvi-0003YX-Mu for qemu-devel@nongnu.org; Tue, 14 Sep 2021 12:05:08 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48834) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQAvY-00053N-2e for qemu-devel@nongnu.org; Tue, 14 Sep 2021 12:05:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631635494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fwSgd185T8jrnRcPRkYx6E8h8fWkH+f8/s0umRpbj/o=; b=KrSd0f6jE2tpywIRe4J1WsD6MFNnoU2q8OwVZto51Nf6CO8VGdfbPnj+hwEFzl4HQ3cw85 yNVY7nSNtJZGQ1oWJvFe488lZ+ZgVvY0hDzLEmDTER7p5qHWeoDyJMZegaLqqFU66hud+u derxa8bZLBLIaUWtrIgdW2fLzVTq598= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-579-tM_0rvS0PLSRQ1fpaHj9gg-1; Tue, 14 Sep 2021 12:04:53 -0400 X-MC-Unique: tM_0rvS0PLSRQ1fpaHj9gg-1 Received: by mail-wr1-f71.google.com with SMTP id i16-20020adfded0000000b001572ebd528eso4129654wrn.19 for ; Tue, 14 Sep 2021 09:04:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fwSgd185T8jrnRcPRkYx6E8h8fWkH+f8/s0umRpbj/o=; b=DIIp0X0SbeQVnmzVnKfIMsJHydDl5d3f2WFAneTe95WFtuq6gZFOMP0sqjp2ixuMry iG1XZNKXopxups+sFYIO87UePV3/LBJ6Rssz7OQYz8M1JBQ+rjQXibc20ttZHNvSrJwG 8vfJNapdNDJG6vqwVf3iaHMnd2xPEenFX8zfsDlAcaxwjuk4DG0m/8baTgBCYZVO892w gGS4u25tLbs0tqEXR/dUdRVQnoE9NW9kAPjYAUI7a/SyHY4M5Qwar1VIrlruIDclUL/P uuZGl1eDs8ObSTk9swkChR8lPNNbicUvPObwGTIlhr8avsg12FQPOzOh8FNN64jT72Oi LmZg== X-Gm-Message-State: AOAM530Ik15Ih2+syGj7E7Yovw79KVS7Tt0MwVbY+ZbA+76gY4GX1KpX 8/McvYjT/h/qFXzbRZKNhOUH9dJTGKgn6Vcywz1JnGUBd9jr8h57bw0r0PPA2Tev3jJDhNmjZmy 4Q+i0ULBQrbBMxLI= X-Received: by 2002:a5d:630a:: with SMTP id i10mr13306080wru.178.1631635492514; Tue, 14 Sep 2021 09:04:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxY9W8uuOq3x1502lnP8J8q4zQpVGcDdUWnjNiVmHX/lPv+I8nnf5Ku5qeSObPZKEx55QkDUQ== X-Received: by 2002:a5d:630a:: with SMTP id i10mr13306025wru.178.1631635492254; Tue, 14 Sep 2021 09:04:52 -0700 (PDT) Received: from [192.168.1.36] (14.red-83-35-25.dynamicip.rima-tde.net. [83.35.25.14]) by smtp.gmail.com with ESMTPSA id q7sm5175176wru.56.2021.09.14.09.04.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Sep 2021 09:04:51 -0700 (PDT) Subject: Re: [PATCH v2 30/53] qapi: introduce x-query-roms QMP command To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-devel@nongnu.org References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-31-berrange@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <342ccd00-7210-1169-fb9d-3fad8d3c3470@redhat.com> Date: Tue, 14 Sep 2021 18:04:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210914142042.1655100-31-berrange@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -44 X-Spam_score: -4.5 X-Spam_bar: ---- X-Spam_report: (-4.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.398, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.969, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Cornelia Huck , David Hildenbrand , Bin Meng , Mark Cave-Ayland , Yuval Shaia , Peter Xu , Max Filippov , Taylor Simpson , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Eric Blake , Marek Vasut , Yoshinori Sato , Markus Armbruster , Halil Pasic , Christian Borntraeger , qemu-ppc@nongnu.org, Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , "Dr. David Alan Gilbert" , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Chris Wulff , Laurent Vivier , Palmer Dabbelt , Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: > This is a counterpart to the HMP "info roms" command. It is being > added with an "x-" prefix because this QMP command is intended as an > adhoc debugging tool and will thus not be modelled in QAPI as fully > structured data, nor will it have long term guaranteed stability. > The existing HMP command is rewritten to call the QMP command. > > Signed-off-by: Daniel P. Berrangé > --- > hw/core/loader.c | 55 ++++++++++++++++++++++++++++++++--------------- > qapi/machine.json | 12 +++++++++++ > 2 files changed, 50 insertions(+), 17 deletions(-) > -void hmp_info_roms(Monitor *mon, const QDict *qdict) > +HumanReadableText *qmp_x_query_roms(Error **errp) > { > Rom *rom; > + g_autoptr(GString) buf = g_string_new(""); > + HumanReadableText *ret; > > QTAILQ_FOREACH(rom, &roms, next) { > if (rom->mr) { > - monitor_printf(mon, "%s" > - " size=0x%06zx name=\"%s\"\n", > - memory_region_name(rom->mr), > - rom->romsize, > - rom->name); > + g_string_append_printf(buf, "%s" > + " size=0x%06zx name=\"%s\"\n", > + memory_region_name(rom->mr), > + rom->romsize, > + rom->name); > } else if (!rom->fw_file) { > - monitor_printf(mon, "addr=" TARGET_FMT_plx > - " size=0x%06zx mem=%s name=\"%s\"\n", > - rom->addr, rom->romsize, > - rom->isrom ? "rom" : "ram", > - rom->name); > + g_string_append_printf(buf, "addr=" TARGET_FMT_plx > + " size=0x%06zx mem=%s name=\"%s\"\n", > + rom->addr, rom->romsize, > + rom->isrom ? "rom" : "ram", > + rom->name); > } else { > - monitor_printf(mon, "fw=%s/%s" > - " size=0x%06zx name=\"%s\"\n", > - rom->fw_dir, > - rom->fw_file, > - rom->romsize, > - rom->name); > + g_string_append_printf(buf, "fw=%s/%s" > + " size=0x%06zx name=\"%s\"\n", > + rom->fw_dir, > + rom->fw_file, > + rom->romsize, > + rom->name); > } > } > + > + ret = g_new0(HumanReadableText, 1); > + ret->human_readable_text = g_steal_pointer(&buf->str); > + return ret; > +} Is it possible to have an helper in 'qapi/qmp/smth.h' such: HumanReadableText *qmp_human_readable_text_new(GString **pbuf) { HumanReadableText *ret = g_new0(HumanReadableText, 1); ret->human_readable_text = g_steal_pointer(pbuf); return ret; } ?