From: Thomas Huth <thuth@redhat.com>
To: "Zhao Liu" <zhao1.liu@linux.intel.com>,
"Michael Tokarev" <mjt@tls.msk.ru>,
"Laurent Vivier" <laurent@vivier.eu>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Zhenyu Wang <zhenyu.z.wang@intel.com>,
Zhao Liu <zhao1.liu@intel.com>
Subject: Re: [RFC 1/3] scripts/checkpatch: Check common spelling be default
Date: Mon, 4 Dec 2023 10:07:12 +0100 [thread overview]
Message-ID: <342cd1f2-b30b-4844-a479-a9e09648efd7@redhat.com> (raw)
In-Reply-To: <20231204082917.2430223-2-zhao1.liu@linux.intel.com>
On 04/12/2023 09.29, Zhao Liu wrote:
> From: Zhao Liu <zhao1.liu@intel.com>
>
> Add the check for common spelling mistakes for QEMU, which stole
> selling.txt from Linux kernel and referenced the Linux kernel's
You need to sellcheck^Wspellcheck the above line ;-)
> implementation in checkpatch.pl.
>
> This check covers common spelling mistakes, and can be updated/
> extended as per QEMU's realities.
>
> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
> ---
> scripts/checkpatch.pl | 44 ++
> scripts/spelling.txt | 1713 +++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 1757 insertions(+)
> create mode 100644 scripts/spelling.txt
I like the idea of having spellchecking in checkpatch.pl ... not sure though
if we need both, this patch and support for codespell. If you ask me, I'd
just go with the next codespell patch and avoid adding a full spelling.txt
file here ... but if others like this patch here, too, I'm also fine with it.
Thomas
next prev parent reply other threads:[~2023-12-04 9:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 8:29 [RFC 0/3] scripts/checkpatch: Add code spelling check Zhao Liu
2023-12-04 8:29 ` [RFC 1/3] scripts/checkpatch: Check common spelling be default Zhao Liu
2023-12-04 9:07 ` Thomas Huth [this message]
2023-12-05 3:24 ` Zhao Liu
2023-12-04 8:29 ` [RFC 2/3] scripts/checkpatch: Add --codespell and --codespellfile options Zhao Liu
2023-12-04 8:29 ` [RFC 3/3] scripts/spelling: Add common spelling mistakes in default spelling.txt Zhao Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=342cd1f2-b30b-4844-a479-a9e09648efd7@redhat.com \
--to=thuth@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=zhao1.liu@intel.com \
--cc=zhao1.liu@linux.intel.com \
--cc=zhenyu.z.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).