From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CA59C433C1 for ; Thu, 25 Mar 2021 09:41:48 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A188761934 for ; Thu, 25 Mar 2021 09:41:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A188761934 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lPMUs-0005rl-L1 for qemu-devel@archiver.kernel.org; Thu, 25 Mar 2021 05:41:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36708) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lPMTZ-0004vA-RO for qemu-devel@nongnu.org; Thu, 25 Mar 2021 05:40:26 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:28833) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lPMTV-00012e-M7 for qemu-devel@nongnu.org; Thu, 25 Mar 2021 05:40:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616665218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ybhcc5geIY08QUFeHHdQGwbx/Gk2F9IRaxOo5vK+O9k=; b=GrMYm2uuY5SUzeJ6OPZ8JKmNqPfJuYhQYKlSXxaBGy55YbLaaLdbI2uaTwYXH/KAPUYzwN qAl1QbWcCAiiPZrqRVDC8c9lUvSidMj+TPB1/YQHyCSADkFkYMOzP1tvDqtscRaWYv89Si 3tzr41Ovqn8iSJzmNkGyq5rnY5Njld4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-590-bFco39YbOS2P9TSnTfFsOg-1; Thu, 25 Mar 2021 05:40:16 -0400 X-MC-Unique: bFco39YbOS2P9TSnTfFsOg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B3DD087A83A; Thu, 25 Mar 2021 09:40:15 +0000 (UTC) Received: from [10.36.115.72] (ovpn-115-72.ams2.redhat.com [10.36.115.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2A5F1196A8; Thu, 25 Mar 2021 09:40:04 +0000 (UTC) Subject: Re: [PATCH v4 09/14] util/mmap-alloc: Pass flags instead of separate bools to qemu_ram_mmap() To: Peter Xu References: <20210319101230.21531-1-david@redhat.com> <20210319101230.21531-10-david@redhat.com> <20210323204913.GL6486@xz-x1> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <3438a238-39d6-5585-f9fd-014c474bdeb0@redhat.com> Date: Thu, 25 Mar 2021 10:40:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210323204913.GL6486@xz-x1> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=david@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marcel Apfelbaum , Igor Kotrasinski , Eduardo Habkost , "Michael S. Tsirkin" , Murilo Opsfelder Araujo , Richard Henderson , "Dr. David Alan Gilbert" , qemu-devel@nongnu.org, Greg Kurz , Stefan Hajnoczi , Igor Mammedov , Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 23.03.21 21:49, Peter Xu wrote: > On Fri, Mar 19, 2021 at 11:12:25AM +0100, David Hildenbrand wrote: >> Let's pass flags instead of bools to prepare for passing other flags and >> update the documentation of qemu_ram_mmap(). Introduce new QEMU_MAP_ >> flags that abstract the mmap() PROT_ and MAP_ flag handling and simplify >> it. >> >> We expose only flags that are currently supported by qemu_ram_mmap(). >> Maybe, we'll see qemu_mmap() in the future as well that can implement these >> flags. >> >> Note: We don't use MAP_ flags as some flags (e.g., MAP_SYNC) are only >> defined for some systems and we want to always be able to identify >> these flags reliably inside qemu_ram_mmap() -- for example, to properly >> warn when some future flags are not available or effective on a system. >> Also, this way we can simplify PROT_ handling as well. >> >> Signed-off-by: David Hildenbrand >> --- >> include/qemu/mmap-alloc.h | 16 +++++++++------- >> include/qemu/osdep.h | 18 ++++++++++++++++++ >> softmmu/physmem.c | 8 +++++--- >> util/mmap-alloc.c | 15 ++++++++------- >> util/oslib-posix.c | 3 ++- >> 5 files changed, 42 insertions(+), 18 deletions(-) >> >> diff --git a/include/qemu/mmap-alloc.h b/include/qemu/mmap-alloc.h >> index 456ff87df1..a60a2085b3 100644 >> --- a/include/qemu/mmap-alloc.h >> +++ b/include/qemu/mmap-alloc.h >> @@ -7,18 +7,22 @@ size_t qemu_fd_getpagesize(int fd); >> size_t qemu_mempath_getpagesize(const char *mem_path); >> >> /** >> - * qemu_ram_mmap: mmap the specified file or device. >> + * qemu_ram_mmap: mmap anonymous memory, the specified file or device. >> + * >> + * mmap() abstraction to map guest RAM, simplifying flag handling, taking >> + * care of alignment requirements and installing guard pages. >> * >> * Parameters: >> * @fd: the file or the device to mmap >> * @size: the number of bytes to be mmaped >> * @align: if not zero, specify the alignment of the starting mapping address; >> * otherwise, the alignment in use will be determined by QEMU. >> - * @readonly: true for a read-only mapping, false for read/write. >> - * @shared: map has RAM_SHARED flag. >> - * @is_pmem: map has RAM_PMEM flag. >> + * @qemu_map_flags: QEMU_MAP_* flags >> * @map_offset: map starts at offset of map_offset from the start of fd >> * >> + * Internally, MAP PRIVATE, MAP_ANONYMOUS and MAP_SHARED_VALIDATE are set > ^ > | > +---- underscore > Nice catch, thanks :) -- Thanks, David / dhildenb