From: Richard Henderson <richard.henderson@linaro.org>
To: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>,
qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: Alistair.Francis@wdc.com, palmer@dabbelt.com, bin.meng@windriver.com
Subject: Re: [RFC PATCH 1/4] target/riscv: Use xl instead of mxl for disassemble
Date: Wed, 24 Aug 2022 09:30:13 -0700 [thread overview]
Message-ID: <3440bcf4-e7d6-a0c4-0606-76754aad6986@linaro.org> (raw)
In-Reply-To: <20220824130331.21315-2-zhiwei_liu@linux.alibaba.com>
On 8/24/22 06:03, LIU Zhiwei wrote:
> Disassemble function(plugin_disas, target_disas, monitor_disas) will
> always call set_disas_info before disassembling instructions.
>
> plugin_disas and target_disas will always be called under a TB, which
> has the same XLEN.
>
> We can't ensure that monitor_disas will always be called under a TB,
> but current XLEN will still be a better choice, thus we can ensure at
> least the disassemble of the nearest one TB is right.
>
> Signed-off-by: LIU Zhiwei<zhiwei_liu@linux.alibaba.com>
> ---
> target/riscv/cpu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-08-24 16:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-24 13:03 [RFC PATCH 0/4] Support multiple deocde path for RISC-V LIU Zhiwei
2022-08-24 13:03 ` [RFC PATCH 1/4] target/riscv: Use xl instead of mxl for disassemble LIU Zhiwei
2022-08-24 16:30 ` Richard Henderson [this message]
2022-08-29 10:08 ` Alistair Francis
2022-08-24 13:03 ` [RFC PATCH 2/4] disas/riscv: Move down the struct rv_decode LIU Zhiwei
2022-08-24 13:03 ` [RFC PATCH 3/4] disas/riscv: Add used_opcode_data field LIU Zhiwei
2022-08-24 13:03 ` [RFC PATCH 4/4] target/riscv: Support Ventana disassemble LIU Zhiwei
2022-08-30 9:03 ` Alistair Francis
2022-08-30 12:54 ` LIU Zhiwei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3440bcf4-e7d6-a0c4-0606-76754aad6986@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Alistair.Francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).