From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Thomas Huth <thuth@redhat.com>,
Yuval Shaia <yuval.shaia.ml@gmail.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
qemu-devel@nongnu.org
Cc: "Markus Armbruster" <armbru@redhat.com>,
"Zhijian Li" <lizhijian@fujitsu.com>,
"Peter Xu" <peterx@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
libvir-list@redhat.com, "Juan Quintela" <quintela@redhat.com>,
"Eric Auger" <eric.auger@redhat.com>,
"Fabiano Rosas" <farosas@suse.de>,
"Michael Tokarev" <mjt@tls.msk.ru>
Subject: Re: [PATCH] hw/rdma: Deprecate the pvrdma device and the rdma subsystem
Date: Thu, 5 Oct 2023 07:03:58 +0200 [thread overview]
Message-ID: <344dcdcb-cb10-9cca-df24-5451c444475c@linaro.org> (raw)
In-Reply-To: <20230927133019.228495-1-thuth@redhat.com>
On 27/9/23 15:30, Thomas Huth wrote:
> This subsystem is said to be in a bad shape (see e.g. [1], [2]
> and [3]), and nobody seems to feel responsible to pick up patches
> for this and send them via a pull request. For example there is
> a patch for a CVE-worthy bug posted more than half a year ago [4]
> which has never been merged.
>
> Quoting Markus: "Given the shape it is in, I wouldn't let friends
> use it in production" - we shouldn't expose this to our users in
> the current state. Thus let's mark it as deprecated and finally
> remove it unless somebody steps up and improves the code quality
> and adds proper regression tests.
>
> [1] https://lore.kernel.org/qemu-devel/20230918144206.560120-1-armbru@redhat.com/
> [2] https://lore.kernel.org/qemu-devel/ZQnojJOqoFu73995@redhat.com/
> [3] https://lore.kernel.org/qemu-devel/1054981c-e8ae-c676-3b04-eeb030e11f65@tls.msk.ru/
> [4] https://lore.kernel.org/qemu-devel/20230301142926.18686-1-yuval.shaia.ml@gmail.com/
> [5] https://lore.kernel.org/qemu-devel/8734z9f086.fsf@pond.sub.org/
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> MAINTAINERS | 2 +-
> docs/about/deprecated.rst | 8 ++++++++
> hw/rdma/vmw/pvrdma_main.c | 2 ++
> 3 files changed, 11 insertions(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-10-05 5:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-27 13:30 [PATCH] hw/rdma: Deprecate the pvrdma device and the rdma subsystem Thomas Huth
2023-09-27 19:13 ` Markus Armbruster
2023-09-28 5:28 ` Markus Armbruster
2023-10-04 14:04 ` Juan Quintela
2023-10-05 5:03 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=344dcdcb-cb10-9cca-df24-5451c444475c@linaro.org \
--to=philmd@linaro.org \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eric.auger@redhat.com \
--cc=farosas@suse.de \
--cc=libvir-list@redhat.com \
--cc=lizhijian@fujitsu.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mjt@tls.msk.ru \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=thuth@redhat.com \
--cc=yuval.shaia.ml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).