From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org,
"Daniel P . Berrange" <berrange@redhat.com>
Subject: Re: [PATCH] tests: Fix "make check-functional" for targets without thorough tests
Date: Thu, 18 Sep 2025 14:52:58 +0200 [thread overview]
Message-ID: <34517c98-21ea-4fd2-8798-d2c901b3ad0f@redhat.com> (raw)
In-Reply-To: <CAFEAcA8qwgQoGrU1phd+ozQMtWdo=Jt_XNCtaxPysoqaLxd16w@mail.gmail.com>
On 18/09/2025 13.51, Peter Maydell wrote:
> On Thu, 18 Sept 2025 at 12:40, Thomas Huth <thuth@redhat.com> wrote:
>>
>> From: Thomas Huth <thuth@redhat.com>
>>
>> If QEMU gets configured for a single target that does not have
>> any thorough functional tests, "make check-functional" currently
>> fails with the error message "No rule to make target 'check-func'".
>> This happens because "check-func" only gets defined for thorough
>> tests (quick ones get added to "check-func-quick" instead).
>> Thus let's define a dummy target for this case, that simply
>> depends on the quick tests.
>
> Tested-by: Peter Maydell <peter.maydell@linaro.org>
>
> We also have the opposite problem if there are no 'quick'
> tests, which you can see if you try 'check-functional'
> on a build configured with the aarch64-linux-user target only:
Yes, looks like we have to define both targets in Makefile.include, just in
case of such situations. I just sent a v2 to fix it.
Thomas
prev parent reply other threads:[~2025-09-18 12:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-18 11:40 [PATCH] tests: Fix "make check-functional" for targets without thorough tests Thomas Huth
2025-09-18 11:51 ` Peter Maydell
2025-09-18 12:52 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34517c98-21ea-4fd2-8798-d2c901b3ad0f@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).