qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luca Bonissi <qemu@bonslack.org>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
	Laurent Vivier <laurent@vivier.eu>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH 1/7] Add termios2 support to linux-user
Date: Wed, 3 Dec 2025 15:37:20 +0100	[thread overview]
Message-ID: <345301f3-c75d-40e8-92c8-0c5525da250f@bonslack.org> (raw)
In-Reply-To: <aTAp6fZ7f8hYupbh@redhat.com>

On 03/12/25 13:15, Daniel P. Berrangé wrote:
> You've added this for a handful of archiecture targets, but
> in Fedora we're seeing the incompatibility affect s390x and
> aarch64 too, which this series hasn't implemented.

The patch is for all targets, but some specific targets use a custom 
termbits.h include file and require the addition of the structures 
and/or TCGETS2/TCSETS2 defines that was missing.

Specifically, s390x and aarch64 use the generic/termbits.h include that 
was already ok.

> BTW, ideally send a cover letter with a multi-patch
> series; there are tools which make this easier than
> using git send-email directly:
> 
>    https://www.qemu.org/docs/master/devel/submitting-a-patch.html#submitting-your-patches

Thank! I will use git send-email the next time.

Luca


  reply	other threads:[~2025-12-03 14:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-31 13:23 [PATCH 1/7] Add termios2 support to linux-user Luca Bonissi
2025-11-02 10:29 ` Andreas Schwab
2025-12-03 12:15 ` Daniel P. Berrangé
2025-12-03 14:37   ` Luca Bonissi [this message]
2025-12-04 12:48 ` Heinrich Schuchardt
2025-12-15 16:42 ` Icenowy Zheng
2025-12-16  6:26   ` Icenowy Zheng
2025-12-15 16:44 ` Icenowy Zheng
  -- strict thread matches above, loose matches on Subject: below --
2025-08-30 13:14 Luca Bonissi
2025-08-31 13:45 ` Andreas Schwab
2025-10-31 12:42   ` Luca Bonissi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=345301f3-c75d-40e8-92c8-0c5525da250f@bonslack.org \
    --to=qemu@bonslack.org \
    --cc=berrange@redhat.com \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).