From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: Palmer Dabbelt <palmer@dabbelt.com>, qemu-devel@nongnu.org
Cc: Palmer Dabbelt <palmer@sifive.com>,
Michael Clark <mjc@sifive.com>,
Sagar Karandikar <sagark@eecs.berkeley.edu>,
Riku Voipio <riku.voipio@iki.fi>
Subject: Re: [Qemu-devel] [PATCH] linux-user: Implement renameat2 when defined
Date: Thu, 21 Dec 2017 14:49:56 +0100 [thread overview]
Message-ID: <345662bb-caee-3d5f-3494-900d9becfbcc@mail.uni-paderborn.de> (raw)
In-Reply-To: <20171220002941.14560-1-palmer@dabbelt.com>
On 12/20/2017 01:29 AM, Palmer Dabbelt wrote:
> From: Palmer Dabbelt <palmer@sifive.com>
>
> The RISC-V Linux port was recently accept upstream and will be released
> as part of 4.15. While working on our glibc port I discovered that
> qemu's user-mode emulation doesn't support renameat2, which has replaced
> rename as part of the default system call list for new architectures.
> Since a bunch of commonly used functionality boils down to rename (and
> now renameat2), we ended up with many failures.
>
> This patch adds support for renameat2. As I'm not familiar with QEMU
> development, I haven't really testing anything more than a simple
> "./configure; make" on the upstream codebase, but I did test this
> against our (not yet upstream) QEMU port where it appears to work for
> me. I've just cobbled it together by copying the existing renameat
> implementation, but as there appears to be no glibc wrapper for
> renameat2 on either of the systems I've tried this on I just emited the
> system call directly.
>
CC'ed linux-user maintainer Riku Voipio.
Cheers,
Bastian
next prev parent reply other threads:[~2017-12-21 13:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 0:29 [Qemu-devel] [PATCH] linux-user: Implement renameat2 when defined Palmer Dabbelt
2017-12-20 15:14 ` no-reply
2017-12-21 13:49 ` Bastian Koppelmann [this message]
2017-12-21 14:01 ` Peter Maydell
2017-12-21 16:29 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=345662bb-caee-3d5f-3494-900d9becfbcc@mail.uni-paderborn.de \
--to=kbastian@mail.uni-paderborn.de \
--cc=mjc@sifive.com \
--cc=palmer@dabbelt.com \
--cc=palmer@sifive.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=sagark@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).