From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH] scsi: fix sense code for EREMOTEIO
Date: Tue, 9 Mar 2021 15:22:35 +0100 [thread overview]
Message-ID: <34591ce5-0470-3eb2-3138-f57ad51905db@redhat.com> (raw)
In-Reply-To: <369adbbf-5ec4-2e1a-2df1-f9277123ac3f@redhat.com>
On 09/03/21 15:14, Philippe Mathieu-Daudé wrote:
>> SENSE_CODE(LUN_COMM_FAILURE) has an ABORTED COMMAND sense key,
>> so it results in a retry in Linux. To ensure that EREMOTEIO
>> is forwarded to the guest, use a HARDWARE ERROR sense key
>> instead. Note that the code before commit d7a84021d was incorrect
>> because it used HARDWARE_ERROR as a SCSI status, not as a sense
>> key.
>
> It is not clear whether if it deserves a 'Fixes: d7a84021db8 ("scsi:
> introduce scsi_sense_from_errno()")' or not...
Yes, why not. That was in turn a bugfix but not the best.
Paolo
>> Reported-by: Marc-André Lureau<marcandre.lureau@redhat.com>
>> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> Reviewed-by: Philippe Mathieu-Daudé<philmd@redhat.com>
>
prev parent reply other threads:[~2021-03-09 14:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 13:57 [PATCH] scsi: fix sense code for EREMOTEIO Paolo Bonzini
2021-03-09 14:14 ` Philippe Mathieu-Daudé
2021-03-09 14:22 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34591ce5-0470-3eb2-3138-f57ad51905db@redhat.com \
--to=pbonzini@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).