From: Eric Blake <eblake@redhat.com>
To: Zhang Chen <zhangckid@gmail.com>,
qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Juan Quintela <quintela@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Markus Armbruster <armbru@redhat.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>,
Li Zhijian <lizhijian@cn.fujitsu.com>,
Zhang Chen <chen.zhang@intel.com>
Subject: Re: [Qemu-devel] [PATCH V9 11/20] qapi/migration.json: Rename COLO unknown mode to none mode.
Date: Thu, 28 Jun 2018 16:19:18 -0500 [thread overview]
Message-ID: <3464fd15-6b1c-b524-0445-58fb352c1b42@redhat.com> (raw)
In-Reply-To: <20180627204136.4177-12-zhangckid@gmail.com>
On 06/27/2018 03:41 PM, Zhang Chen wrote:
> From: Zhang Chen <chen.zhang@intel.com>
>
> Suggested by Markus Armbruster rename COLO unknown mode to none mode.
>
> Signed-off-by: Zhang Chen <chen.zhang@intel.com>
> ---
> migration/colo-failover.c | 2 +-
> migration/colo.c | 2 +-
> qapi/migration.json | 10 +++++-----
> 3 files changed, 7 insertions(+), 7 deletions(-)
> # Since: 2.8
> ##
> { 'enum': 'COLOMode',
> - 'data': [ 'unknown', 'primary', 'secondary'] }
> + 'data': [ 'none', 'primary', 'secondary'] }
The deletion of 'unknown' could potentially be a user-visible regression
visible if COLOMode were in a QMP command; but thankfully the generated
qapi/qapi-introspect.c does not seem to cover this enum, so it just
affects internal code for now.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-06-28 21:19 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 20:41 [Qemu-devel] [PATCH V9 00/20] COLO: integrate colo frame with block replication and COLO proxy Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 01/20] filter-rewriter: Add TCP state machine and fix memory leak in connection_track_table Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 02/20] colo-compare: implement the process of checkpoint Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 03/20] colo-compare: use notifier to notify packets comparing result Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 04/20] COLO: integrate colo compare with colo frame Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 05/20] COLO: Add block replication into colo process Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 06/20] COLO: Remove colo_state migration struct Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 07/20] COLO: Load dirty pages into SVM's RAM cache firstly Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 08/20] ram/COLO: Record the dirty pages that SVM received Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 09/20] COLO: Flush memory data from ram cache Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 10/20] qmp event: Add COLO_EXIT event to notify users while exited COLO Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 11/20] qapi/migration.json: Rename COLO unknown mode to none mode Zhang Chen
2018-06-28 21:19 ` Eric Blake [this message]
2018-06-29 9:14 ` Dr. David Alan Gilbert
2018-06-30 2:00 ` Zhang Chen
2018-07-03 10:57 ` Markus Armbruster
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 12/20] qapi: Add new command to query colo status Zhang Chen
2018-07-03 11:09 ` Markus Armbruster
2018-07-04 12:25 ` Zhang Chen
2018-07-04 14:39 ` Markus Armbruster
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 13/20] savevm: split the process of different stages for loadvm/savevm Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 14/20] COLO: flush host dirty ram from cache Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 15/20] net/net.c: Add net client type check function for COLO Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 16/20] filter: Add handle_event method for NetFilterClass Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 17/20] filter-rewriter: handle checkpoint and failover event Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 18/20] COLO: notify net filters about checkpoint/failover event Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 19/20] COLO: quick failover process by kick COLO thread Zhang Chen
2018-06-27 20:41 ` [Qemu-devel] [PATCH V9 20/20] docs: Add COLO status diagram to COLO-FT.txt Zhang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3464fd15-6b1c-b524-0445-58fb352c1b42@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=chen.zhang@intel.com \
--cc=dgilbert@redhat.com \
--cc=jasowang@redhat.com \
--cc=lizhijian@cn.fujitsu.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=zhang.zhanghailiang@huawei.com \
--cc=zhangckid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).