From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: marcandre.lureau@redhat.com, vr_qemu@t-online.de
Subject: Re: [PATCH v2] meson: move -no-pie from linker to compiler
Date: Tue, 23 May 2023 07:08:55 -0700 [thread overview]
Message-ID: <3466d603-ebde-0d26-ae40-6b805bbc2af5@linaro.org> (raw)
In-Reply-To: <20230523073029.19549-1-pbonzini@redhat.com>
On 5/23/23 00:30, Paolo Bonzini wrote:
> The large comment in the patch says it all; the -no-pie flag is broken and
> this is why it was not included in QEMU_LDFLAGS before commit a988b4c5614
> ("build: move remaining compiler flag tests to meson", 2023-05-18). And
> some distros made things even worse, so we have to add it to the compiler
> command line.
>
> Resolves:https://gitlab.com/qemu-project/qemu/-/issues/1664
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> meson.build | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Tested-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2023-05-23 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 7:30 [PATCH v2] meson: move -no-pie from linker to compiler Paolo Bonzini
2023-05-23 8:16 ` Philippe Mathieu-Daudé
2023-05-23 14:08 ` Richard Henderson [this message]
2023-05-24 6:04 ` Volker Rümelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3466d603-ebde-0d26-ae40-6b805bbc2af5@linaro.org \
--to=richard.henderson@linaro.org \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vr_qemu@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).