qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 03/25] hw/s390x/s390-stattrib: Include missing 'exec/target_page.h' header
Date: Wed, 1 Oct 2025 07:49:43 -0700	[thread overview]
Message-ID: <3479f480-da67-41a1-85fd-c1d281575694@linaro.org> (raw)
In-Reply-To: <20251001082127.65741-4-philmd@linaro.org>

On 10/1/25 01:21, Philippe Mathieu-Daudé wrote:
> The "exec/target_page.h" header is indirectly pulled from
> "system/ram_addr.h". Include it explicitly, in order to
> avoid unrelated issues when refactoring "system/ram_addr.h":
> 
>    hw/s390x/s390-stattrib-kvm.c: In function ‘kvm_s390_stattrib_set_stattr’:
>    hw/s390x/s390-stattrib-kvm.c:89:57: error: ‘TARGET_PAGE_SIZE’ undeclared (first use in this function); did you mean ‘TARGET_PAGE_BITS’?
>       89 |     unsigned long max = s390_get_memory_limit(s390ms) / TARGET_PAGE_SIZE;
>          |                                                         ^~~~~~~~~~~~~~~~
>          |                                                         TARGET_PAGE_BITS
> 
> Since "system/ram_addr.h" is actually not needed, remove it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>   hw/s390x/s390-stattrib-kvm.c | 2 +-
>   hw/s390x/s390-stattrib.c     | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2025-10-01 14:52 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-01  8:21 [PATCH 00/25] system/physmem: Extract API out of 'system/ram_addr.h' header Philippe Mathieu-Daudé
2025-10-01  8:21 ` [PATCH 01/25] system/ram_addr: Remove unnecessary 'exec/cpu-common.h' header Philippe Mathieu-Daudé
2025-10-01  8:41   ` Thomas Huth
2025-10-01 14:30   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 02/25] accel/kvm: Include missing 'exec/target_page.h' header Philippe Mathieu-Daudé
2025-10-01 14:30   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 03/25] hw/s390x/s390-stattrib: " Philippe Mathieu-Daudé
2025-10-01 14:49   ` Richard Henderson [this message]
2025-10-06 13:01   ` Thomas Huth
2025-10-01  8:21 ` [PATCH 04/25] hw/vfio/listener: " Philippe Mathieu-Daudé
2025-10-01 14:50   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 05/25] target/arm/tcg/mte: " Philippe Mathieu-Daudé
2025-10-01 14:50   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 06/25] hw: Remove unnecessary 'system/ram_addr.h' header Philippe Mathieu-Daudé
2025-10-01 14:53   ` Richard Henderson
2025-10-06 13:02   ` Thomas Huth
2025-10-06 13:12   ` Michael S. Tsirkin
2025-10-01  8:21 ` [PATCH 07/25] accel/tcg: Document rcu_read_lock is held when calling tlb_reset_dirty() Philippe Mathieu-Daudé
2025-10-01 14:58   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 08/25] accel/tcg: Rename @start argument of tlb_reset_dirty*() Philippe Mathieu-Daudé
2025-10-01 15:06   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 09/25] system/physmem: Rename @start argument of physical_memory_get_dirty() Philippe Mathieu-Daudé
2025-10-01  8:21 ` [PATCH 10/25] system/physmem: Un-inline cpu_physical_memory_get_dirty_flag() Philippe Mathieu-Daudé
2025-10-01 15:07   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 11/25] system/physmem: Un-inline cpu_physical_memory_is_clean() Philippe Mathieu-Daudé
2025-10-01 15:09   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 12/25] system/physmem: Rename @start argument of physical_memory_all_dirty() Philippe Mathieu-Daudé
2025-10-01  8:21 ` [PATCH 13/25] system/physmem: Rename @start argument of physical_memory_range*() Philippe Mathieu-Daudé
2025-10-01  8:21 ` [PATCH 14/25] system/physmem: Un-inline cpu_physical_memory_range_includes_clean() Philippe Mathieu-Daudé
2025-10-01 15:15   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 15/25] system/physmem: Un-inline cpu_physical_memory_set_dirty_flag() Philippe Mathieu-Daudé
2025-10-01 15:16   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 16/25] system/physmem: Rename @start argument of physical_memory_*range() Philippe Mathieu-Daudé
2025-10-01  8:21 ` [PATCH 17/25] system/physmem: Un-inline cpu_physical_memory_set_dirty_range() Philippe Mathieu-Daudé
2025-10-01 15:17   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 18/25] system/physmem: Un-inline cpu_physical_memory_set_dirty_lebitmap() Philippe Mathieu-Daudé
2025-10-01 15:23   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 19/25] system/physmem: Rename @start argument of physmem_dirty_bits_cleared() Philippe Mathieu-Daudé
2025-10-01  8:21 ` [PATCH 20/25] system/physmem: Un-inline cpu_physical_memory_dirty_bits_cleared() Philippe Mathieu-Daudé
2025-10-01 15:50   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 21/25] system/physmem: Rename @start argument of physmem_test_and_clear_dirty() Philippe Mathieu-Daudé
2025-10-01  8:21 ` [PATCH 22/25] system/physmem: Reduce cpu_physical_memory_clear_dirty_range() scope Philippe Mathieu-Daudé
2025-10-01 15:51   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 23/25] system/physmem: Reduce cpu_physical_memory_sync_dirty_bitmap() scope Philippe Mathieu-Daudé
2025-10-01 15:53   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 24/25] system/physmem: Drop 'cpu_' prefix in Physical Memory API Philippe Mathieu-Daudé
2025-10-01 15:54   ` Richard Henderson
2025-10-01  8:21 ` [PATCH 25/25] system/physmem: Extract API out of 'system/ram_addr.h' header Philippe Mathieu-Daudé
2025-10-01 15:55   ` Richard Henderson
2025-10-01  8:25 ` [PATCH 00/25] " Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3479f480-da67-41a1-85fd-c1d281575694@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).