From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54128) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1da3wC-0005Td-Uc for qemu-devel@nongnu.org; Tue, 25 Jul 2017 13:48:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1da3wA-0004H6-Cy for qemu-devel@nongnu.org; Tue, 25 Jul 2017 13:48:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57436) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1da3wA-0004Gv-6Y for qemu-devel@nongnu.org; Tue, 25 Jul 2017 13:48:02 -0400 Date: Tue, 25 Jul 2017 13:47:59 -0400 (EDT) From: Paolo Bonzini Message-ID: <349062488.18968647.1501004879602.JavaMail.zimbra@redhat.com> In-Reply-To: <20170725171302.GK1587@perard.uk.xensource.com> References: <20170725171302.GK1587@perard.uk.xensource.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] QEMU commit 04bf2526ce breaks use of xen-mapcache List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony PERARD Cc: Stefano Stabellini , xen-devel@lists.xen.org, qemu-devel@nongnu.org > Hi, > > Commits 04bf2526ce (exec: use qemu_ram_ptr_length to access guest ram) > start using qemu_ram_ptr_length() instead of qemu_map_ram_ptr(). > That result in calling xen_map_cache() with lock=true, but this mapping > is never invalidated. > So QEMU use more and more RAM until it stop working for a reason or an > other. (crash if host have little RAM or stop emulating but no crash) > > I don't know if calling xen_invalidate_map_cache_entry() in > address_space_read_continue() and address_space_write_continue() is the > right answer. Is there something better to do ? I think it's correct for dma to be true... maybe add a lock argument to qemu_ram_ptr_length, so that make address_space_{read,write}_continue can pass 0 and everyone else passes 1? Paolo