From: Thomas Huth <thuth@redhat.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: Re: [PATCH 1/3] gitlab: add a CI job for running checkpatch.pl
Date: Tue, 13 Oct 2020 10:08:56 +0200 [thread overview]
Message-ID: <34ecfca3-e8f1-4faa-d55d-df40310f08a0@redhat.com> (raw)
In-Reply-To: <20200918132903.1848939-2-berrange@redhat.com>
On 18/09/2020 15.29, Daniel P. Berrangé wrote:
> This job is advisory since it is expected that certain patches will fail
> the style checks and checkpatch.pl provides no way to mark exceptions to
> the rules.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> .gitlab-ci.d/check-patch.py | 48 +++++++++++++++++++++++++++++++++++++
> .gitlab-ci.yml | 12 ++++++++++
> 2 files changed, 60 insertions(+)
> create mode 100755 .gitlab-ci.d/check-patch.py
[...]
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index a18e18b57e..3ed724c720 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -369,3 +369,15 @@ check-crypto-only-gnutls:
> variables:
> IMAGE: centos7
> MAKE_CHECK_ARGS: check
> +
> +
> +check-patch:
> + stage: test
Would it be ok to move this to the "build" stage, so that the job does not
have to wait for all the slow build jobs to finish?
(same question applies for the next patch, too)
If you agree, I can do the change when picking up the patches, no need to
resend just because of this.
Thomas
next prev parent reply other threads:[~2020-10-13 8:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 13:29 [PATCH 0/3] gitlab: add jobs for checking paches Daniel P. Berrangé
2020-09-18 13:29 ` [PATCH 1/3] gitlab: add a CI job for running checkpatch.pl Daniel P. Berrangé
2020-09-18 13:46 ` Philippe Mathieu-Daudé
2020-10-13 8:08 ` Thomas Huth [this message]
2020-10-13 8:09 ` Daniel P. Berrangé
2020-09-18 13:29 ` [PATCH 2/3] gitlab: add a CI job to validate the DCO sign off Daniel P. Berrangé
2020-09-18 13:29 ` [PATCH 3/3] gitlab: assign python helper files to GitLab maintainers section Daniel P. Berrangé
2020-09-18 13:47 ` Philippe Mathieu-Daudé
2020-09-18 13:36 ` [PATCH 0/3] gitlab: add jobs for checking paches no-reply
2020-09-18 13:54 ` no-reply
2020-09-18 14:07 ` Thomas Huth
2020-09-18 14:10 ` Philippe Mathieu-Daudé
2020-09-18 14:15 ` Daniel P. Berrangé
2020-09-18 14:19 ` 罗勇刚(Yonggang Luo)
2020-09-18 14:57 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34ecfca3-e8f1-4faa-d55d-df40310f08a0@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).