From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cxboA-0000Jr-Sv for qemu-devel@nongnu.org; Mon, 10 Apr 2017 12:04:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cxboA-00064O-0N for qemu-devel@nongnu.org; Mon, 10 Apr 2017 12:04:50 -0400 References: From: John Snow Message-ID: <34fe2331-2471-81bc-60f7-247fb81b55d3@redhat.com> Date: Mon, 10 Apr 2017 12:04:35 -0400 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 for-2.10 0/8] RBD reopen, read_only cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com, qemu-block@nongnu.org On 04/07/2017 04:55 PM, Jeff Cody wrote: > Changes from v1: > > Patch 2: Has v1 patch 8 (do not blindly xset bs->read_only) squashed into it > (thanks Stefan) > COW -> "copy-on-read" (Thanks John) > Drop unneeded call in vvfat, and bypass enable_write_target (Stefan) > > Patch 5: Rename bdrv_try_... to bdrv_can_set_read_only() (Thanks John, Stefan) > > Patch 6: Use "reopen_state->flags" not "reopen_state->bs->open_flags" > (Thanks John) > > > > This series does two things: > > 1.) Cleans up some of the logic behind setting the read_only flag > for a BDS in the block layer, so that it is done consistently > (and rules are applied consistently), and > > 2.) Adds .bdrv_reopen_prepare() implementation for RBD, so that block > jobs can be run on backing chains that have rbd protocol nodes. > > Jeff Cody (8): > block: add bdrv_set_read_only() helper function > block: do not set BDS read_only if copy_on_read enabled > block: honor BDRV_O_ALLOW_RDWR when clearing bs->read_only > block: code movement > block: introduce bdrv_can_set_read_only() > block: use bdrv_can_set_read_only() during reopen > block/rbd - update variable names to more apt names > block/rbd: Add support for reopen() > > block.c | 56 +++++++++++++++++++++++++++++++++++--------- > block/bochs.c | 5 +++- > block/cloop.c | 5 +++- > block/dmg.c | 6 ++++- > block/rbd.c | 65 +++++++++++++++++++++++++++++++++++++-------------- > block/vvfat.c | 19 +++++++++++---- > include/block/block.h | 2 ++ > 7 files changed, 123 insertions(+), 35 deletions(-) > Reviewed-by: John Snow