From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1521C433F5 for ; Sun, 20 Feb 2022 21:52:09 +0000 (UTC) Received: from localhost ([::1]:48672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nLu7k-0002tK-IC for qemu-devel@archiver.kernel.org; Sun, 20 Feb 2022 16:52:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34010) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLu6t-0002Br-CM for qemu-devel@nongnu.org; Sun, 20 Feb 2022 16:51:16 -0500 Received: from kylie.crudebyte.com ([5.189.157.229]:41067) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nLu6q-0003Wq-HP for qemu-devel@nongnu.org; Sun, 20 Feb 2022 16:51:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=kylie; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=jRRVh0VrFbvUr4aLg9aurVLFW4gCPOgUXhOExpd5ne4=; b=k2RN0Lr7uqTR5Brpm3tSdN8VgS N76ayxDnxbqD6jPV4AIYpZ0hC5z+jxAu42upsXByuxeaGznexwfBijtjJ7Vqzz6Je9OKHujtMdiD5 GE0CEkXLNEPEMVJ/cJ2hE/zB6b1eEuL7VXjCXhjtLsh907MygxV0gGdVRCmp9QdouDcrv1gUJKr/A 22KdUa2hjKgFAddBdQYIZI4hKuwKvfubmOkH/G29ozAqU75h6YfiUzoK0Llb2SXgGTzEGq5EG5n2w 9WtuVOzhEi10wHIptRi4NBBNNrOFYILA+cn/nLkLqvohr1inNG65qWJXlBvFFnuSC6RAFY2xqL1Qs FFf6YGucxONfWVH7fZh+p4fbAV9fSd+T5q9mNSjTo+CQi4S9B0OOYKNqDbz88WuSg6qfFqYsDY5bi qGjKkvT3dLbOMJ0W0lr7wMr8zUj5W58bwRy2mDSqvvQyY6CTFuC3MgWqI3NohOm3z8Y1HEUhP+FHj Gnx0EzU9BxS811+UF2YpKYS9jRM65ZbzGNInXbOhFbr+jiBvFtYh70aA58mqQaGFg1L8853jxIFlK lif5pUvrfbu//WFrFdTDbhWNrxeibQPblF0rYlHI2dVnFnmnA9MJsv/w4/U9n+BsD82EdS8CUA67k ovM3BP2QJQSMZfCmBhT8HzpkEmQd7EtqYgObxSlkQ=; From: Christian Schoenebeck To: qemu-devel@nongnu.org Cc: Will Cohen , Laurent Vivier , Thomas Huth , Philippe =?ISO-8859-1?Q?Mathieu=2DDaud=E9?= , Greg Kurz , hi@alyssa.is, Michael Roitzsch , Paolo Bonzini , Keno Fischer Subject: Re: [PATCH v8 09/11] 9p: darwin: Implement compatibility for mknodat Date: Sun, 20 Feb 2022 22:51:08 +0100 Message-ID: <35009708.HEDLKCRaxn@silver> In-Reply-To: <20220220165056.72289-10-wwcohen@gmail.com> References: <20220220165056.72289-1-wwcohen@gmail.com> <20220220165056.72289-10-wwcohen@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: pass client-ip=5.189.157.229; envelope-from=qemu_oss@crudebyte.com; helo=kylie.crudebyte.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sonntag, 20. Februar 2022 17:50:54 CET Will Cohen wrote: > From: Keno Fischer > > Darwin does not support mknodat. However, to avoid race conditions > with later setting the permissions, we must avoid using mknod on > the full path instead. We could try to fchdir, but that would cause > problems if multiple threads try to call mknodat at the same time. > However, luckily there is a solution: Darwin includes a function > that sets the cwd for the current thread only. > This should suffice to use mknod safely. > > This function (pthread_fchdir_np) is protected by a check in > meson in a patch later in this series. > > Signed-off-by: Keno Fischer > Signed-off-by: Michael Roitzsch > [Will Cohen: - Adjust coding style > - Replace clang references with gcc > - Note radar filed with Apple for missing syscall > - Replace direct syscall with pthread_fchdir_np and > adjust patch notes accordingly > - Move qemu_mknodat from 9p-util to osdep and os-posix > - Move pthread_fchdir_np declaration only to osdep > - Declare pthread_fchdir_np with > - __attribute__((weak_import)) to allow checking for > its presence before usage > - Move declarations above cplusplus guard > - Add CONFIG_PTHREAD_FCHDIR_NP to meson and check for > presence in osdep.h and os-posix.c > - Rebase to apply cleanly on top of the 2022-02-10 > changes to 9pfs] > Signed-off-by: Will Cohen > --- > hw/9pfs/9p-local.c | 4 ++-- > include/qemu/osdep.h | 12 ++++++++++++ > meson.build | 1 + > os-posix.c | 35 +++++++++++++++++++++++++++++++++++ > 4 files changed, 50 insertions(+), 2 deletions(-) > > diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c > index a0d08e5216..d42ce6d8b8 100644 > --- a/hw/9pfs/9p-local.c > +++ b/hw/9pfs/9p-local.c > @@ -682,7 +682,7 @@ static int local_mknod(FsContext *fs_ctx, V9fsPath > *dir_path, > > if (fs_ctx->export_flags & V9FS_SM_MAPPED || > fs_ctx->export_flags & V9FS_SM_MAPPED_FILE) { > - err = mknodat(dirfd, name, fs_ctx->fmode | S_IFREG, 0); > + err = qemu_mknodat(dirfd, name, fs_ctx->fmode | S_IFREG, 0); > if (err == -1) { > goto out; > } > @@ -697,7 +697,7 @@ static int local_mknod(FsContext *fs_ctx, V9fsPath > *dir_path, } > } else if (fs_ctx->export_flags & V9FS_SM_PASSTHROUGH || > fs_ctx->export_flags & V9FS_SM_NONE) { > - err = mknodat(dirfd, name, credp->fc_mode, credp->fc_rdev); > + err = qemu_mknodat(dirfd, name, credp->fc_mode, credp->fc_rdev); > if (err == -1) { > goto out; > } > diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h > index ce12f64853..c0f442d791 100644 > --- a/include/qemu/osdep.h > +++ b/include/qemu/osdep.h > @@ -818,6 +818,18 @@ static inline int > platform_does_not_support_system(const char *command) */ > struct dirent *qemu_dirent_dup(struct dirent *dent); > > +/* > + * As long as mknodat is not available on macOS, this workaround > + * using pthread_fchdir_np is needed. qemu_mknodat is defined in > + * os-posix.c. pthread_fchdir_np is weakly linked here as a guard > + * in case it disappears in future macOS versions, because it is > + * is a private API. > + */ > +#if defined CONFIG_DARWIN && defined CONFIG_PTHREAD_FCHDIR_NP > +int pthread_fchdir_np(int fd) __attribute__((weak_import)); > +#endif > +int qemu_mknodat(int dirfd, const char *filename, mode_t mode, dev_t dev); > + > #ifdef __cplusplus > } > #endif > diff --git a/meson.build b/meson.build > index ae5f7eec6e..6fdc0281ad 100644 > --- a/meson.build > +++ b/meson.build > @@ -1557,6 +1557,7 @@ config_host_data.set('CONFIG_POSIX_FALLOCATE', > cc.has_function('posix_fallocate' > config_host_data.set('CONFIG_POSIX_MEMALIGN', > cc.has_function('posix_memalign')) config_host_data.set('CONFIG_PPOLL', > cc.has_function('ppoll')) > config_host_data.set('CONFIG_PREADV', cc.has_function('preadv', prefix: > '#include ')) +config_host_data.set('CONFIG_PTHREAD_FCHDIR_NP', > cc.has_function('pthread_fchdir_np')) > config_host_data.set('CONFIG_SEM_TIMEDWAIT', > cc.has_function('sem_timedwait', dependencies: threads)) > config_host_data.set('CONFIG_SENDFILE', cc.has_function('sendfile')) > config_host_data.set('CONFIG_SETNS', cc.has_function('setns') and > cc.has_function('unshare')) diff --git a/os-posix.c b/os-posix.c > index ae6c9f2a5e..ccc3d1e9d3 100644 > --- a/os-posix.c > +++ b/os-posix.c > @@ -332,3 +332,38 @@ int os_mlock(void) > return -ENOSYS; > #endif > } > + > +/* > + * As long as mknodat is not available on macOS, this workaround > + * using pthread_fchdir_np is needed. > + * > + * Radar filed with Apple for implementing mknodat: > + * rdar://FB9862426 (https://openradar.appspot.com/FB9862426) > + */ > +#if defined CONFIG_DARWIN && defined CONFIG_PTHREAD_FCHDIR_NP > + > +int qemu_mknodat(int dirfd, const char *filename, mode_t mode, dev_t dev) > +{ > + int preserved_errno, err; > + if (!pthread_fchdir_np) { > + error_report_once("pthread_fchdir_np() is not available on this > version of macOS"); Code style error: ERROR: line over 90 characters #226: FILE: os-posix.c:349: + error_report_once("pthread_fchdir_np() is not available on this version of macOS"); BTW, does anybody know what happened to our Patchew bot that used to automatically report such errors to the list? Best regards, Christian Schoenebeck > + return -ENOTSUP; > + } > + if (pthread_fchdir_np(dirfd) < 0) { > + return -1; > + } > + err = mknod(filename, mode, dev); > + preserved_errno = errno; > + /* Stop using the thread-local cwd */ > + pthread_fchdir_np(-1); > + if (err < 0) { > + errno = preserved_errno; > + } > + return err; > +} > +#else > +int qemu_mknodat(int dirfd, const char *filename, mode_t mode, dev_t dev) > +{ > + return mknodat(dirfd, filename, mode, dev); > +} > +#endif