From: Li Zhijian <lizhijian@cn.fujitsu.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: qemu-devel@nongnu.org, Michael Tsirkin <mst@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
zhijianx.li@intel.com, Philippe Mathieu Daude <philmd@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 3/4] i386: import & use bootparam.h
Date: Fri, 11 Jan 2019 18:03:41 +0800 [thread overview]
Message-ID: <3517ec7b-87e7-bc38-0ec5-d85cf4fc6a31@cn.fujitsu.com> (raw)
In-Reply-To: <CAGxU2F4M22Vz6xTauvHAngzp6PMfzAkTqbmGfsA=5rwWYnZi_w@mail.gmail.com>
Hi Stefano
On 1/11/19 17:48, Stefano Garzarella wrote:
> Hi Li,
>
> On Fri, Jan 11, 2019 at 10:06 AM Li Zhijian <lizhijian@cn.fujitsu.com> wrote:
>> + # unnecessary import of several video/ist/etc headers
>> + sed -e '/__ASSEMBLY__/,/__ASSEMBLY__/d' $tmpdir/include/asm/bootparam.h > $tmpdir/bootparam.h
>> + cp_portable $tmpdir/bootparam.h "$output/include/standard-headers/asm-$arch"
> Maybe you miss my comment. Anyway, IMHO is better to use the double
> quotes for all paths.
>
> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
So sorry about it, i folded it on a wrong branch at the beginning.
will update it soon.
Thanks
next prev parent reply other threads:[~2019-01-11 10:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 8:57 [Qemu-devel] [PATCH v5 0/4] allow to load initrd below 4G for recent kernel Li Zhijian
2019-01-11 8:57 ` [Qemu-devel] [PATCH v5 1/4] unify len and addr type for memory/address APIs Li Zhijian
2019-01-11 8:57 ` [Qemu-devel] [PATCH v5 2/4] hw/core/loader.c: Read as long as possible in load_image_size() Li Zhijian
2019-01-11 8:57 ` [Qemu-devel] [PATCH v5 3/4] i386: import & use bootparam.h Li Zhijian
2019-01-11 9:48 ` Stefano Garzarella
2019-01-11 10:03 ` Li Zhijian [this message]
2019-01-11 8:57 ` [Qemu-devel] [PATCH v5 4/4] i386: allow to load initrd below 4G for recent linux Li Zhijian
2019-01-14 17:53 ` Eduardo Habkost
2019-01-15 1:35 ` Li Zhijian
2019-01-15 1:46 ` Michael S. Tsirkin
2019-01-16 10:19 ` Li Zhijian
2019-01-13 14:32 ` [Qemu-devel] [PATCH v5 0/4] allow to load initrd below 4G for recent kernel no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3517ec7b-87e7-bc38-0ec5-d85cf4fc6a31@cn.fujitsu.com \
--to=lizhijian@cn.fujitsu.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=zhijianx.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).