From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52466)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1bx9L1-0002MF-89
	for qemu-devel@nongnu.org; Thu, 20 Oct 2016 05:08:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1bx9Kw-0006uE-95
	for qemu-devel@nongnu.org; Thu, 20 Oct 2016 05:08:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34108)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <thuth@redhat.com>) id 1bx9Kw-0006t5-3o
	for qemu-devel@nongnu.org; Thu, 20 Oct 2016 05:08:30 -0400
References: <1476786796-15269-1-git-send-email-anand.indukala@gmail.com>
	<CANDALv=6f_gTA2hbXWj6ybbmKQq3AAgJi-H6kPpapYN0_Cz-4g@mail.gmail.com>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <351dd6d1-df9b-91c3-87d7-e46fade9bc30@redhat.com>
Date: Thu, 20 Oct 2016 11:08:26 +0200
MIME-Version: 1.0
In-Reply-To: <CANDALv=6f_gTA2hbXWj6ybbmKQq3AAgJi-H6kPpapYN0_Cz-4g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/2] script/clean-includes: added duplicate
 #include check
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anand J <anand.indukala@gmail.com>, qemu-devel@nongnu.org

On 18.10.2016 14:38, Anand J wrote:
> 
> 
> On Tue, Oct 18, 2016 at 4:03 PM, Anand J <anand.indukala@gmail.com
> <mailto:anand.indukala@gmail.com>> wrote:
> 
>     Added script to check duplicate #include entries. This check will scan
>     and print the files in which duplicate #include entries are present.
> 
>     Script might output false positive entries as well. Such entries should
>     not be removed. So if it finds any duplicate entries script will
>     terminate with an exit status 1. Then each and every file should be
>     checked manually and corrected if necessary.
> 
>     In order to enable the check use --check-duphead option with
>     script/clean-includes.
> 
>     Signed-off-by: Anand J <anand.indukala@gmail.com
>     <mailto:anand.indukala@gmail.com>>
>     ---
>      scripts/clean-includes | 50
>     +++++++++++++++++++++++++++++++++++++-------------
>      1 file changed, 37 insertions(+), 13 deletions(-)

Thanks for the update, this patch looks fine to me now, so feel free to
add my:

Reviewed-by: Thomas Huth <thuth@redhat.com>

But please avoid sending patches in HTML e-mails. Could you maybe please
resend the patch as plain text mail? And while you're at it, add CC: to
qemu-trivial@nongnu.org, I think the patch is simple enough to go
through the trivial tree.

 Thanks,
  Thomas