From: Richard Henderson <richard.henderson@linaro.org>
To: Joseph Myers <joseph@codesourcery.com>,
qemu-devel@nongnu.org, pbonzini@redhat.com, rth@twiddle.net,
ehabkost@redhat.com
Subject: Re: [PATCH 1/4] target/i386: fix floating-point load-constant rounding
Date: Tue, 19 May 2020 11:08:53 -0700 [thread overview]
Message-ID: <3539dece-d72e-936f-97ad-5094834f6aa7@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.21.2005132348310.11687@digraph.polyomino.org.uk>
On 5/13/20 4:49 PM, Joseph Myers wrote:
> The implementations of the fldl2t, fldl2e, fldpi, fldlg2 and fldln2
> instructions load fixed constants independent of the rounding mode.
> Fix them to load a value correctly rounded for the current rounding
> mode (but always rounded to 64-bit precision independent of the
> precision control, and without setting "inexact") as specified.
>
> Signed-off-by: Joseph Myers <joseph@codesourcery.com>
> ---
> target/i386/fpu_helper.c | 54 +++++++-
> tests/tcg/i386/test-i386-fldcst.c | 199 ++++++++++++++++++++++++++++++
> 2 files changed, 248 insertions(+), 5 deletions(-)
> create mode 100644 tests/tcg/i386/test-i386-fldcst.c
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-05-19 18:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 23:48 [PATCH 0/4] target/i386: miscellaneous x87 fixes Joseph Myers
2020-05-13 23:49 ` [PATCH 1/4] target/i386: fix floating-point load-constant rounding Joseph Myers
2020-05-19 18:08 ` Richard Henderson [this message]
2020-05-13 23:50 ` [PATCH 2/4] target/i386: fix fxam handling of invalid encodings Joseph Myers
2020-05-13 23:51 ` [PATCH 3/4] target/i386: fix fbstp handling of negative zero Joseph Myers
2020-05-13 23:51 ` [PATCH 4/4] target/i386: fix fbstp handling of out-of-range values Joseph Myers
2020-05-14 6:21 ` [PATCH 0/4] target/i386: miscellaneous x87 fixes no-reply
2020-05-14 14:31 ` Joseph Myers
2020-06-02 18:38 ` Joseph Myers
2020-06-04 18:02 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3539dece-d72e-936f-97ad-5094834f6aa7@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ehabkost@redhat.com \
--cc=joseph@codesourcery.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).