From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, berrange@redhat.com, qemu-block@nongnu.org,
libvir-list@redhat.com, richard.henderson@linaro.org,
mreitz@redhat.com
Subject: Re: [PATCH v4 0/4] Drop deprecated floppy config & bogus -drive if=T
Date: Thu, 11 Mar 2021 20:17:48 -0500 [thread overview]
Message-ID: <353e5606-ce1f-bdb1-bb1d-c29505c97ec9@redhat.com> (raw)
In-Reply-To: <20210311075221.1795266-1-armbru@redhat.com>
On 3/11/21 2:52 AM, Markus Armbruster wrote:
> v4:
> * PATCH 3: Move a declaration into a loop [Richard]
> * PATCH 4: Drop a superfluous call to drive_check_orphaned() [Daniel],
> fix comments [John]
>
> v3:
> * PATCH 1: New [Daniel]
>
> v2:
> * Rebased, straightforward conflict with commit f5d33dd51f
> "hw/block/fdc: Remove the check_media_rate property" resolved
> * PATCH 2: Commit message fixed [Kevin]
>
> Markus Armbruster (4):
> docs/system/deprecated: Fix note on fdc drive properties
> fdc: Drop deprecated floppy configuration
> fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common()
> blockdev: Drop deprecated bogus -drive interface type
>
> docs/system/deprecated.rst | 33 --
> docs/system/removed-features.rst | 56 +++
> include/sysemu/blockdev.h | 1 -
> blockdev.c | 37 +-
> hw/block/fdc.c | 73 +---
> softmmu/vl.c | 11 +-
> tests/qemu-iotests/172 | 31 +-
> tests/qemu-iotests/172.out | 562 +------------------------------
> 8 files changed, 82 insertions(+), 722 deletions(-)
>
Reviewed-by: John Snow <jsnow@redhat.com>
Tentatively staged, pending CI:
https://gitlab.com/jsnow/qemu/-/pipelines/269277138
--js
prev parent reply other threads:[~2021-03-12 1:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-11 7:52 [PATCH v4 0/4] Drop deprecated floppy config & bogus -drive if=T Markus Armbruster
2021-03-11 7:52 ` [PATCH v4 1/4] docs/system/deprecated: Fix note on fdc drive properties Markus Armbruster
2021-03-11 7:52 ` [PATCH v4 2/4] fdc: Drop deprecated floppy configuration Markus Armbruster
2021-03-11 7:52 ` [PATCH v4 3/4] fdc: Inline fdctrl_connect_drives() into fdctrl_realize_common() Markus Armbruster
2021-03-11 7:52 ` [PATCH v4 4/4] blockdev: Drop deprecated bogus -drive interface type Markus Armbruster
2021-03-11 9:44 ` Daniel P. Berrangé
2021-03-12 1:17 ` John Snow [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=353e5606-ce1f-bdb1-bb1d-c29505c97ec9@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).