From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E08F7C433E0 for ; Sat, 6 Feb 2021 17:58:46 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4594764E2E for ; Sat, 6 Feb 2021 17:58:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4594764E2E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l8Rr3-0001CS-54 for qemu-devel@archiver.kernel.org; Sat, 06 Feb 2021 12:58:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47938) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l8Rq5-0000gb-3n for qemu-devel@nongnu.org; Sat, 06 Feb 2021 12:57:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:22995) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1l8Rq0-0004ev-Mr for qemu-devel@nongnu.org; Sat, 06 Feb 2021 12:57:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612634256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Fxq3c6rkh/W4qe9DOSGRD/nx7Ze2dDULgpMzZydYTb0=; b=D1QBPYy+qNAvYrlPrJFlJZQJ8qtvOvxbggAFE2MgM80apVymPRcBptS/Gk/t2N72SLEvr9 tvshsecDkaaUCZfJGxN2AUw4F7zaF0qExIsKareneraDTh7JTtg9ugA1fEl9Cf/pPp1PH5 vcuYKHz01m1uJsdCoyBxuT6apUmtd9g= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-272-WGv5d1RQOWKL0AuvMRcH_A-1; Sat, 06 Feb 2021 12:57:35 -0500 X-MC-Unique: WGv5d1RQOWKL0AuvMRcH_A-1 Received: by mail-wr1-f70.google.com with SMTP id s18so8195113wrf.0 for ; Sat, 06 Feb 2021 09:57:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Fxq3c6rkh/W4qe9DOSGRD/nx7Ze2dDULgpMzZydYTb0=; b=Rwh2oSEuSrx2JX6jdUIdG2mUY4Gc39meYYu4u2gzOtqc7kJg0upuedzkROkgkwfFOc BnPT1TRzJn7/5TmqSp4Ggr7faBhBF0LeXp9iRjgX7pmMcNANAaOIR6o7PIWGzvfQLAWm usp7JsRnwTjcqPtbBwoLSnVaB+eCmwIPaY1uHGtkrQ44wBRUNZiIToTQgnl4EwYM5uEE JyJqMvwDYB4ZGm91uCVA7fIDosdOzxu6O5FEDBJG3Fd5Rtkn/Mq2Rdo6SQwjMP6aLSA3 hGp3wapZALxqTT/zz90N8MQGcOMNwrOoY7ZKhFmPxSFRteaaeP5PAv1g0IZZZNuW+qBk SO+Q== X-Gm-Message-State: AOAM533kxpPrW+CvPebxT4F5TKJSyZ+77AvA5DxzgpO59UVxOwgrEpgF J5pE2S2bLC2vWnJU1ex8i/eRaNPICyN3dhL2L1Z+jA5hRqcbtUVzmGo6Ts8dykmTZQdkxgrWMJF jFki8V9Cy+Y18MJo= X-Received: by 2002:a1c:7e4e:: with SMTP id z75mr8370435wmc.168.1612634253839; Sat, 06 Feb 2021 09:57:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJys+QaSaSqtH67gjZFYPEdlGVn+B4n5YpHys0rgQ6CDtfgzMOt9sVC/1SqvcKhVE9pSDu89dg== X-Received: by 2002:a1c:7e4e:: with SMTP id z75mr8370420wmc.168.1612634253645; Sat, 06 Feb 2021 09:57:33 -0800 (PST) Received: from [192.168.1.36] (68.red-83-57-175.dynamicip.rima-tde.net. [83.57.175.68]) by smtp.gmail.com with ESMTPSA id x13sm6958444wmc.27.2021.02.06.09.57.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 Feb 2021 09:57:32 -0800 (PST) Subject: Re: [PULL v3 11/27] multi-process: setup PCI host bridge for remote device To: Stefan Hajnoczi , Peter Maydell , qemu-devel@nongnu.org References: <20210205164459.432714-1-stefanha@redhat.com> <20210205164459.432714-12-stefanha@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <353e7615-4860-d0d0-1f52-b448559e7629@redhat.com> Date: Sat, 6 Feb 2021 18:57:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210205164459.432714-12-stefanha@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=philmd@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -32 X-Spam_score: -3.3 X-Spam_bar: --- X-Spam_report: (-3.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.353, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.105, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , John G Johnson , Thomas Huth , Jagannathan Raman , Eduardo Habkost , qemu-block@nongnu.org, "Michael S. Tsirkin" , "Denis V. Lunev" , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , Elena Ufimtseva , Wainer dos Santos Moschetta , Igor Mammedov , Paolo Bonzini , =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/5/21 5:44 PM, Stefan Hajnoczi wrote: > From: Jagannathan Raman > > PCI host bridge is setup for the remote device process. It is > implemented using remote-pcihost object. It is an extension of the PCI > host bridge setup by QEMU. > Remote-pcihost configures a PCI bus which could be used by the remote > PCI device to latch on to. > > Signed-off-by: Jagannathan Raman > Signed-off-by: John G Johnson > Signed-off-by: Elena Ufimtseva > Reviewed-by: Stefan Hajnoczi > Message-id: 0871ba857abb2eafacde07e7fe66a3f12415bfb2.1611938319.git.jag.raman@oracle.com > Signed-off-by: Stefan Hajnoczi > --- > MAINTAINERS | 2 + > include/hw/pci-host/remote.h | 29 ++++++++++++++ > hw/pci-host/remote.c | 75 ++++++++++++++++++++++++++++++++++++ > hw/pci-host/Kconfig | 3 ++ > hw/pci-host/meson.build | 1 + > hw/remote/Kconfig | 1 + > 6 files changed, 111 insertions(+) > create mode 100644 include/hw/pci-host/remote.h > create mode 100644 hw/pci-host/remote.c ... > +static const TypeInfo remote_pcihost_info = { > + .name = TYPE_REMOTE_PCIHOST, > + .parent = TYPE_PCIE_HOST_BRIDGE, ^^^^^^^^^^^^^^^^^^^^^ > + .instance_size = sizeof(RemotePCIHost), > + .class_init = remote_pcihost_class_init, > +}; > + > +static void remote_pcihost_register(void) > +{ > + type_register_static(&remote_pcihost_info); > +} > + > +type_init(remote_pcihost_register) > diff --git a/hw/pci-host/Kconfig b/hw/pci-host/Kconfig > index eb03f0489d..8b8c763c28 100644 > --- a/hw/pci-host/Kconfig > +++ b/hw/pci-host/Kconfig > @@ -65,3 +65,6 @@ config PCI_POWERNV > select PCI_EXPRESS > select MSI_NONBROKEN > select PCIE_PORT > + > +config REMOTE_PCIHOST > + bool select CONFIG_PCI_EXPRESS ? (Reported by Peter Maydell on s390x) Side question, does it make sense to enable this feature by default on all architectures? Regards, Phil.