qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Miki Mishael <mmishael@redhat.com>
To: qemu-devel@nongnu.org
Cc: Yan Vugenfirer <yvugenfi@redhat.com>,
	Michael Roth <mdroth@linux.vnet.ibm.com>,
	Adam Litke <aglitke@linux.vnet.ibm.com>,
	Ronen Hod <rhod@redhat.com>,
	Anthony Liguori <aliguori@amazon.com>,
	Dmitry Fleytman <dfleytma@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V2] qemu-ga: isa-serial support on Windows
Date: Wed, 5 Feb 2014 13:21:42 -0500 (EST)	[thread overview]
Message-ID: <355206941.8636179.1391624502129.JavaMail.root@redhat.com> (raw)
In-Reply-To: <1389778424-4482-1-git-send-email-mmishael@redhat.com>

Hello,

I wonder if you have few minutes to review the patch and contribute to apply it to upstream.
I appreciate your help.

Link:
http://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg01823.html

Thanks,

Miki

----- Original Message -----
From: "Miki Mishael" <mmishael@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Yan Vugenfirer" <yvugenfi@redhat.com>, "Michael Roth" <mdroth@linux.vnet.ibm.com>, "Adam Litke" <aglitke@linux.vnet.ibm.com>, "Ronen Hod" <rhod@redhat.com>, "Anthony Liguori" <aliguori@amazon.com>, "Dmitry Fleytman" <dfleytma@redhat.com>
Sent: Wednesday, January 15, 2014 11:33:43 AM
Subject: [Qemu-devel] [PATCH V2] qemu-ga: isa-serial support on Windows

Add support for isa-serial method for qemu-ga on Windows,
Added -p command line parameter for serial port name
specification, e.g. "-p COM15".

Changes since V1:
* define default path for isa-serial for linux, "/dev/ttyS0".
* replaced static void ga_serial_path_correction function for path correction with snprintf.
* minor indentation fix.
* fixed error output when setting timeout for com port fails.

Miki Mishael (1):
  qemu-ga: isa-serial support on Windows

 qga/channel-win32.c | 20 ++++++++++++++++++--
 qga/main.c          | 12 +++++++++---
 2 files changed, 27 insertions(+), 5 deletions(-)

-- 
1.8.3.1

      parent reply	other threads:[~2014-02-05 18:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-15  9:33 [Qemu-devel] [PATCH V2] qemu-ga: isa-serial support on Windows Miki Mishael
2014-01-15  9:33 ` Miki Mishael
2014-02-24  1:00   ` Michael Roth
2014-02-05 18:21 ` Miki Mishael [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=355206941.8636179.1391624502129.JavaMail.root@redhat.com \
    --to=mmishael@redhat.com \
    --cc=aglitke@linux.vnet.ibm.com \
    --cc=aliguori@amazon.com \
    --cc=dfleytma@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rhod@redhat.com \
    --cc=yvugenfi@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).