From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, "Andreas Färber" <afaerber@suse.de>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 4/7] qdev: Introduce DEFINE_PROP_LINK
Date: Wed, 28 Jun 2017 16:06:52 +0200 [thread overview]
Message-ID: <3553624c-4f6a-7671-41d6-db22a2e37003@redhat.com> (raw)
In-Reply-To: <20170628140219.GI14166@lemon.lan>
On 28/06/2017 16:02, Fam Zheng wrote:
>>> It's implemented by creating a wrapper property that basically forwards
>>> operations to a QOM "link-FOO" property, which handles the check
>>> callback and flags. The feature that is missing from QOM is the dynamic
>>> child pointer which is done in the added code with the usual "offset"
>>> approach.
>> Would it be possible to add a ".create" field to PropertyInfo? Then
>> there's no need to introduce the wrapper.
> QOM setter/getter want a LinkProperty opaque pointer, but qdev uses a Property
> pointer. I don't see a way to adapt that with .create(). Can you elaborate?
The .create() callback would call object_property_add_link directly.
There would be no change in the properties at the QOM level, but the
PropertyInfo lets "info qtree" show the property.
Paolo
next prev parent reply other threads:[~2017-06-28 14:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-28 12:48 [Qemu-devel] [PATCH 0/7] qdev: Introduce DEFINE_PROP_LINK Fam Zheng
2017-06-28 12:48 ` [Qemu-devel] [PATCH 1/7] qom: Make link property API public Fam Zheng
2017-06-28 13:32 ` Paolo Bonzini
2017-06-28 13:36 ` Andreas Färber
2017-06-28 14:09 ` Fam Zheng
2017-06-28 12:48 ` [Qemu-devel] [PATCH 2/7] qom: Handle property lookup failure in object_resolve_link Fam Zheng
2017-06-28 12:48 ` [Qemu-devel] [PATCH 3/7] qom: Save type name in LinkProperty Fam Zheng
2017-06-28 12:48 ` [Qemu-devel] [PATCH 4/7] qdev: Introduce DEFINE_PROP_LINK Fam Zheng
2017-06-28 13:38 ` Paolo Bonzini
2017-06-28 14:02 ` Fam Zheng
2017-06-28 14:06 ` Paolo Bonzini [this message]
2017-06-28 14:32 ` Fam Zheng
2017-06-28 12:48 ` [Qemu-devel] [PATCH 5/7] virtio-blk: Use DEFINE_PROP_LINK Fam Zheng
2017-06-28 12:48 ` [Qemu-devel] [PATCH 6/7] virtio-scsi: " Fam Zheng
2017-06-28 12:48 ` [Qemu-devel] [PATCH 7/7] virtio-rng: " Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3553624c-4f6a-7671-41d6-db22a2e37003@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=famz@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).