From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, Kevin Wolf <kwolf@redhat.com>
Cc: Qemu-block <qemu-block@nongnu.org>,
qemu-devel <qemu-devel@nongnu.org>, Doug Gale <doug16k@gmail.com>,
Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Keith Busch <keith.busch@intel.com>
Subject: Re: [Qemu-devel] [Qemu-block] Patch to add helpful tracing output for driver authors in NVMe emulation
Date: Wed, 11 Oct 2017 21:46:49 +0200 [thread overview]
Message-ID: <35705b3e-ccdd-c1af-2dd5-688a1c7e837a@redhat.com> (raw)
In-Reply-To: <CAFEAcA-jb=4eTgD836+darXBLBuDA70pcypON2Bbj3b0SpNTaQ@mail.gmail.com>
On 11/10/2017 15:08, Peter Maydell wrote:
>> Tracing is the right tool to detect bad guest code, and I think it makes
>> sense to mark conditions that shouldn't happen with a correctly
>> operating guest driver. I'm not sure if an exclamation mark is the best
>> syntax for this, because I wouldn't have intuitively understood what
>> it's supposed to tell me.
> We have qemu_log_mask(LOG_GUEST_ERROR, ...) for logging guest errors,
> so I think we should use that.
LOG_GUEST_ERROR is something different too. It means something that is
undefined according to the data sheet more or less, such as accessing a
non-existent reference.
Here the driver does some validation of the values that were written in
the registers, and tells the guest if the validation fails (by putting
something in another registers). Using a tracepoint sounds like the
right thing to do.
Paolo
prev parent reply other threads:[~2017-10-11 19:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 23:18 [Qemu-devel] Patch to add helpful tracing output for driver authors in NVMe emulation Doug Gale
2017-10-06 9:49 ` Kevin Wolf
2017-10-06 13:53 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-10-06 13:50 ` [Qemu-devel] " Eric Blake
2017-10-06 13:54 ` Daniel P. Berrange
2017-10-06 13:58 ` Doug Gale
2017-10-06 14:01 ` Daniel P. Berrange
2017-10-07 7:51 ` Doug Gale
2017-10-09 15:52 ` Eric Blake
2017-10-09 18:44 ` Doug Gale
2017-10-10 6:58 ` Markus Armbruster
2017-10-10 8:02 ` Kevin Wolf
2017-10-11 13:03 ` Doug Gale
2017-10-11 13:08 ` Peter Maydell
2017-10-11 19:46 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35705b3e-ccdd-c1af-2dd5-688a1c7e837a@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=doug16k@gmail.com \
--cc=keith.busch@intel.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).