qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Stefan Weil <sw@weilnetz.de>,
	Sunil Muthuswamy <sunilmut@microsoft.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] configure: Do not intent to build WHPX on 32-bit host
Date: Wed, 9 Sep 2020 20:40:36 +0200	[thread overview]
Message-ID: <357d7fe2-558f-4c3d-d178-742cb9eb6e21@redhat.com> (raw)
In-Reply-To: <20200909182449.360472-1-f4bug@amsat.org>

On 09/09/2020 20.24, Philippe Mathieu-Daudé wrote:
> Hyper-V is available on 64-bit versions of Windows,
> do not try to build its support on 32-bit versions.
> 
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
>  configure | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/configure b/configure
> index 4231d56bcc0..4bd08f5469b 100755
> --- a/configure
> +++ b/configure
> @@ -2989,6 +2989,9 @@ if test "$whpx" != "no" ; then
>          fi
>          whpx="no"
>      fi
> +    if test "$whpx" = "yes" && test "$ARCH" = "i386"; then
> +      error_exit "WHPX requires 64-bit host"
> +    fi
>  fi

I think you should also add a check to the MINGW32 case (see commit
e7a222aeb813a) to prevent that the automatic detection kicks in (so that
you would end up with this error message even if you did not specify
--enable-whpx)

 Thomas



  reply	other threads:[~2020-09-09 18:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-09 18:24 [PATCH] configure: Do not intent to build WHPX on 32-bit host Philippe Mathieu-Daudé
2020-09-09 18:40 ` Thomas Huth [this message]
2020-09-09 18:53   ` Stefan Weil
2020-09-09 20:12     ` [EXTERNAL] " Sunil Muthuswamy
2020-09-11 17:12 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=357d7fe2-558f-4c3d-d178-742cb9eb6e21@redhat.com \
    --to=thuth@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sunilmut@microsoft.com \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).