* [PATCH] configure: Do not intent to build WHPX on 32-bit host
@ 2020-09-09 18:24 Philippe Mathieu-Daudé
2020-09-09 18:40 ` Thomas Huth
2020-09-11 17:12 ` Paolo Bonzini
0 siblings, 2 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2020-09-09 18:24 UTC (permalink / raw)
To: qemu-devel
Cc: Stefan Weil, Sunil Muthuswamy, Philippe Mathieu-Daudé,
Paolo Bonzini
Hyper-V is available on 64-bit versions of Windows,
do not try to build its support on 32-bit versions.
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
configure | 3 +++
1 file changed, 3 insertions(+)
diff --git a/configure b/configure
index 4231d56bcc0..4bd08f5469b 100755
--- a/configure
+++ b/configure
@@ -2989,6 +2989,9 @@ if test "$whpx" != "no" ; then
fi
whpx="no"
fi
+ if test "$whpx" = "yes" && test "$ARCH" = "i386"; then
+ error_exit "WHPX requires 64-bit host"
+ fi
fi
##########################################
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] configure: Do not intent to build WHPX on 32-bit host
2020-09-09 18:24 [PATCH] configure: Do not intent to build WHPX on 32-bit host Philippe Mathieu-Daudé
@ 2020-09-09 18:40 ` Thomas Huth
2020-09-09 18:53 ` Stefan Weil
2020-09-11 17:12 ` Paolo Bonzini
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Huth @ 2020-09-09 18:40 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Stefan Weil, Sunil Muthuswamy, Paolo Bonzini
On 09/09/2020 20.24, Philippe Mathieu-Daudé wrote:
> Hyper-V is available on 64-bit versions of Windows,
> do not try to build its support on 32-bit versions.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> configure | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/configure b/configure
> index 4231d56bcc0..4bd08f5469b 100755
> --- a/configure
> +++ b/configure
> @@ -2989,6 +2989,9 @@ if test "$whpx" != "no" ; then
> fi
> whpx="no"
> fi
> + if test "$whpx" = "yes" && test "$ARCH" = "i386"; then
> + error_exit "WHPX requires 64-bit host"
> + fi
> fi
I think you should also add a check to the MINGW32 case (see commit
e7a222aeb813a) to prevent that the automatic detection kicks in (so that
you would end up with this error message even if you did not specify
--enable-whpx)
Thomas
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] configure: Do not intent to build WHPX on 32-bit host
2020-09-09 18:40 ` Thomas Huth
@ 2020-09-09 18:53 ` Stefan Weil
2020-09-09 20:12 ` [EXTERNAL] " Sunil Muthuswamy
0 siblings, 1 reply; 5+ messages in thread
From: Stefan Weil @ 2020-09-09 18:53 UTC (permalink / raw)
To: Thomas Huth, Philippe Mathieu-Daudé, qemu-devel
Cc: Paolo Bonzini, Sunil Muthuswamy
Am 09.09.20 um 20:40 schrieb Thomas Huth:
> On 09/09/2020 20.24, Philippe Mathieu-Daudé wrote:
>> Hyper-V is available on 64-bit versions of Windows,
>> do not try to build its support on 32-bit versions.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> ---
>> configure | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/configure b/configure
>> index 4231d56bcc0..4bd08f5469b 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2989,6 +2989,9 @@ if test "$whpx" != "no" ; then
>> fi
>> whpx="no"
>> fi
>> + if test "$whpx" = "yes" && test "$ARCH" = "i386"; then
>> + error_exit "WHPX requires 64-bit host"
>> + fi
>> fi
> I think you should also add a check to the MINGW32 case (see commit
> e7a222aeb813a) to prevent that the automatic detection kicks in (so that
> you would end up with this error message even if you did not specify
> --enable-whpx)
>
> Thomas
>
Yes, that's definitely required. The automatic detection currently
enables WHPX for 32 bit builds, too.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [EXTERNAL] Re: [PATCH] configure: Do not intent to build WHPX on 32-bit host
2020-09-09 18:53 ` Stefan Weil
@ 2020-09-09 20:12 ` Sunil Muthuswamy
0 siblings, 0 replies; 5+ messages in thread
From: Sunil Muthuswamy @ 2020-09-09 20:12 UTC (permalink / raw)
To: Stefan Weil, Thomas Huth, Philippe Mathieu-Daudé,
qemu-devel@nongnu.org
Cc: Paolo Bonzini
Signed-off-by: Sunil Muthuswamy <sunilmut@microsoft.com>
> Am 09.09.20 um 20:40 schrieb Thomas Huth:
>
> > On 09/09/2020 20.24, Philippe Mathieu-Daudé wrote:
> >> Hyper-V is available on 64-bit versions of Windows,
> >> do not try to build its support on 32-bit versions.
> >>
> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> >> ---
> >> configure | 3 +++
> >> 1 file changed, 3 insertions(+)
> >>
> >> diff --git a/configure b/configure
> >> index 4231d56bcc0..4bd08f5469b 100755
> >> --- a/configure
> >> +++ b/configure
> >> @@ -2989,6 +2989,9 @@ if test "$whpx" != "no" ; then
> >> fi
> >> whpx="no"
> >> fi
> >> + if test "$whpx" = "yes" && test "$ARCH" = "i386"; then
> >> + error_exit "WHPX requires 64-bit host"
> >> + fi
> >> fi
> > I think you should also add a check to the MINGW32 case (see commit
> > e7a222aeb813a) to prevent that the automatic detection kicks in (so that
> > you would end up with this error message even if you did not specify
> > --enable-whpx)
> >
> > Thomas
> >
>
> Yes, that's definitely required. The automatic detection currently
> enables WHPX for 32 bit builds, too.
>
> Stefan
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] configure: Do not intent to build WHPX on 32-bit host
2020-09-09 18:24 [PATCH] configure: Do not intent to build WHPX on 32-bit host Philippe Mathieu-Daudé
2020-09-09 18:40 ` Thomas Huth
@ 2020-09-11 17:12 ` Paolo Bonzini
1 sibling, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2020-09-11 17:12 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Stefan Weil, Sunil Muthuswamy
On 09/09/20 20:24, Philippe Mathieu-Daudé wrote:
> Hyper-V is available on 64-bit versions of Windows,
> do not try to build its support on 32-bit versions.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> configure | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/configure b/configure
> index 4231d56bcc0..4bd08f5469b 100755
> --- a/configure
> +++ b/configure
> @@ -2989,6 +2989,9 @@ if test "$whpx" != "no" ; then
> fi
> whpx="no"
> fi
> + if test "$whpx" = "yes" && test "$ARCH" = "i386"; then
> + error_exit "WHPX requires 64-bit host"
> + fi
> fi
>
> ##########################################
>
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-09-11 17:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-09-09 18:24 [PATCH] configure: Do not intent to build WHPX on 32-bit host Philippe Mathieu-Daudé
2020-09-09 18:40 ` Thomas Huth
2020-09-09 18:53 ` Stefan Weil
2020-09-09 20:12 ` [EXTERNAL] " Sunil Muthuswamy
2020-09-11 17:12 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).