Re: [PATCH v11 11/18] gdbstub: Infer number of core registers from XML

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 12/10/23 16:45, Akihiko Odaki wrote:
> On 2023/10/12 22:43, Philippe Mathieu-Daudé wrote:
>> Hi Akihiko,
>>
>> On 12/10/23 15:06, Akihiko Odaki wrote:
>>> GDBFeature has the num_regs member so use it where applicable to
>>> remove magic numbers.
>>>
>>> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
>>> ---
>>>   include/hw/core/cpu.h   | 3 ++-
>>>   target/s390x/cpu.h      | 2 --
>>>   gdbstub/gdbstub.c       | 5 ++++-
>>>   target/arm/cpu.c        | 1 -
>>>   target/arm/cpu64.c      | 1 -
>>>   target/avr/cpu.c        | 1 -
>>>   target/hexagon/cpu.c    | 1 -
>>>   target/i386/cpu.c       | 2 --
>>>   target/loongarch/cpu.c  | 2 --
>>>   target/m68k/cpu.c       | 1 -
>>>   target/microblaze/cpu.c | 1 -
>>>   target/riscv/cpu.c      | 1 -
>>>   target/rx/cpu.c         | 1 -
>>>   target/s390x/cpu.c      | 1 -
>>>   14 files changed, 6 insertions(+), 17 deletions(-)
>>>
>>> diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
>>> index 3968369554..11d4b5cd0c 100644
>>> --- a/include/hw/core/cpu.h
>>> +++ b/include/hw/core/cpu.h
>>> @@ -127,7 +127,8 @@ struct SysemuCPUOps;
>>>    * @gdb_adjust_breakpoint: Callback for adjusting the address of a
>>>    *       breakpoint.  Used by AVR to handle a gdb mis-feature with
>>>    *       its Harvard architecture split code and data.
>>> - * @gdb_num_core_regs: Number of core registers accessible to GDB.
>>> + * @gdb_num_core_regs: Number of core registers accessible to GDB or 
>>> 0 to infer
>>> + *                     from @gdb_core_xml_file.
>>>    * @gdb_core_xml_file: File name for core registers GDB XML 
>>> description.
>>>    * @gdb_stop_before_watchpoint: Indicates whether GDB expects the 
>>> CPU to stop
>>>    *           before the insn which triggers a watchpoint rather 
>>> than after it.


>> Why not remove SysemuCPUOps::gdb_num_core_regs entirely?
> 
> It is used by targets without XMLs and ppc, which overrides the number 
> from XML.

Right.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>