qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Su Hang" <suhang16@mails.ucas.ac.cn>
To: thomas huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel]  BiteSizedTasks: API conversion
Date: Mon, 12 Mar 2018 19:24:07 +0800 (GMT+08:00)	[thread overview]
Message-ID: <359ea922.4a3d5.16219f40e21.Coremail.suhang16@mails.ucas.ac.cn> (raw)

Dear Thomas,
I'm tring to work on this job:
BiteSizedTasks:
    API conversion:
        Replace calls to functions named cpu_physical_memory_* with address_space_*.
When I try to replace
`cpu_physical_memory_write_rom(rom->as, rom->addr, rom->data, rom->datasize);`
with
`address_space_write_rom(rom->as, rom->addr, rom->data, rom->datasize);`
gcc complains about:
"""
/home/darcy/workstation/qemu/hw/core/loader.c: In function ‘rom_reset’:
/home/darcy/workstation/qemu/hw/core/loader.c:1098:12: error: implicit declaration of function ‘address_space_write_rom’ [-Werror=implicit-function-declaration]
            address_space_write_rom(rom->as, rom->addr, rom->data,
            ^
/home/darcy/workstation/qemu/hw/core/loader.c:1098:12: error: nested extern declaration of ‘address_space_write_rom’ [-Werror=nested-externs]
cc1: all warnings being treated as errors
/home/darcy/workstation/qemu/rules.mak:66: recipe for target 'hw/core/loader.o' failed
make: *** [hw/core/loader.o] Error 1
"""

Then I use `ag address_space_write_rom` in qemu's root directory,
it failed to find any function named `address_space_write_rom`.

By the way, sorry I don't find tool like `WikiBlame`, to help me find
who add this task. So I can't CC others but you.

Best,
Su Hang

             reply	other threads:[~2018-03-12 11:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-12 11:24 Su Hang [this message]
2018-03-12 11:40 ` [Qemu-devel] BiteSizedTasks: API conversion Peter Maydell
2018-03-12 11:56   ` Su Hang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=359ea922.4a3d5.16219f40e21.Coremail.suhang16@mails.ucas.ac.cn \
    --to=suhang16@mails.ucas.ac.cn \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).