From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20DC3C35247 for ; Mon, 3 Feb 2020 16:05:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBC5720721 for ; Mon, 3 Feb 2020 16:05:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gJjalys3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBC5720721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyeEC-0000Jb-Us for qemu-devel@archiver.kernel.org; Mon, 03 Feb 2020 11:05:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40254) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iyeDL-0007k6-Tt for qemu-devel@nongnu.org; Mon, 03 Feb 2020 11:04:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iyeDK-00026O-UO for qemu-devel@nongnu.org; Mon, 03 Feb 2020 11:04:43 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:35720 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iyeDK-000255-Q0 for qemu-devel@nongnu.org; Mon, 03 Feb 2020 11:04:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1580745882; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PpkNS/BiGXWKlfVqmuvf0DqkXT4vwutsYu4xfnKkt0w=; b=gJjalys3MSQCoSfFnljbhoVhuMN33CrbKOkHK47hoitVbXRXCVCG2t7cVJPGbRTWddnb/f hllQ7u3EE1QVPwqQ5cOuV6VrDI5gW+dVh57GSaykxud+JzrcJR3kHH9kS5BX/1CT8VPJma ODEt/7+457eNrdEycl8Bx45rO9ZcBic= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-29-1yx8WY0PM_OltA8SeB9pWA-1; Mon, 03 Feb 2020 11:04:19 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 914918024D2; Mon, 3 Feb 2020 16:04:18 +0000 (UTC) Received: from [10.3.116.181] (ovpn-116-181.phx2.redhat.com [10.3.116.181]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 37CA9171F4; Mon, 3 Feb 2020 16:04:18 +0000 (UTC) Subject: Re: [PATCH] qga/qapi-schema.json: Fix missing '-' in GuestDiskBusType doc comment To: Peter Maydell , qemu-devel@nongnu.org References: <20200203154905.13252-1-peter.maydell@linaro.org> From: Eric Blake Organization: Red Hat, Inc. Message-ID: <359ec2dd-758b-c21a-3aa1-a60e7eab385b@redhat.com> Date: Mon, 3 Feb 2020 10:04:17 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200203154905.13252-1-peter.maydell@linaro.org> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: 1yx8WY0PM_OltA8SeB9pWA-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/3/20 9:49 AM, Peter Maydell wrote: > The doc comment for GuestDiskBusType doesn't match up with the > enumeration because of a missing hyphen in 'file-backed-virtual'. > This means the docs are rendered wrongly: > "virtual" > Win virtual bus type "file-backed" virtual: Win file-backed bus type > > "file-backed-virtual" > Not documented > > Add the missing hyphen. > > Signed-off-by: Peter Maydell > --- Reviewed-by: Eric Blake > I noticed this while I was working on generation of rST format > documentation from the json doc comments. This is a prerequisite > for that work, so nobody needs to queue this patch (I'll include > it in my series along with some other mere-formatting fixes for > the doc comments) but I thought I might as well send it out > for review now so it doesn't get lost in a big boring-looking > Sphinx/rST patchset :-) > -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org