Re: [Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message

[George Kennedy <george.kennedy@oracle.com>]

Thank you Paolo,

"Signed-off-by: George Kennedy<george.kennedy@oracle.com>"

George

On 12/11/2017 11:55 AM, Paolo Bonzini wrote:
> On 11/12/2017 17:45, George Kennedy wrote:
>> The LSI 53c895a code does not handle the PPR Extended Message. Add
>> support to handle PPR Extended Message like SDTR and WDTR are handled.
>> That is, to skip past the message bytes and ignore the message.
>>
>> ---
>>   hw/scsi/lsi53c895a.c | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c
>> index 595c260..1e02a89 100644
>> --- a/hw/scsi/lsi53c895a.c
>> +++ b/hw/scsi/lsi53c895a.c
>> @@ -961,6 +961,10 @@ static void lsi_do_msgout(LSIState *s)
>>                   DPRINTF("WDTR (ignored)\n");
>>                   lsi_skip_msgbytes(s, 1);
>>                   break;
>> +            case 4:
>> +                DPRINTF("PPR (ignored)\n");
>> +                lsi_skip_msgbytes(s, 5);
>> +                break;
>>               default:
>>                   goto bad;
>>               }
> Hi George,
>
> for a patch to QEMU to be accepted, you need to confirm the origin of
> your patch (according to the "Developer Certificate of Origin", see
> https://developercertificate.org/).
>
> In order to do this, it's enough to reply to this message with
> "Signed-off-by: George Kennedy <george.kennedy@oracle.com>" in the reply.
>
> Thanks,
>
> Paolo