* [Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message [not found] <1511980051-20457-2-git-send-email-george.kennedy@oracle.com> @ 2017-12-07 15:25 ` George Kennedy 2017-12-11 16:45 ` George Kennedy 0 siblings, 1 reply; 5+ messages in thread From: George Kennedy @ 2017-12-07 15:25 UTC (permalink / raw) To: qemu-devel The LSI 53c895a code does not handle the PPR Extended Message. Add support to handle PPR Extended Message like SDTR and WDTR are handled. That is, to skip past the message bytes and ignore the message. --- hw/scsi/lsi53c895a.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 595c260..1e02a89 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -961,6 +961,10 @@ static void lsi_do_msgout(LSIState *s) DPRINTF("WDTR (ignored)\n"); lsi_skip_msgbytes(s, 1); break; + case 4: + DPRINTF("PPR (ignored)\n"); + lsi_skip_msgbytes(s, 5); + break; default: goto bad; } -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message 2017-12-07 15:25 ` [Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message George Kennedy @ 2017-12-11 16:45 ` George Kennedy 2017-12-11 16:55 ` Paolo Bonzini 0 siblings, 1 reply; 5+ messages in thread From: George Kennedy @ 2017-12-11 16:45 UTC (permalink / raw) To: qemu-devel; +Cc: qemu-trivial The LSI 53c895a code does not handle the PPR Extended Message. Add support to handle PPR Extended Message like SDTR and WDTR are handled. That is, to skip past the message bytes and ignore the message. --- hw/scsi/lsi53c895a.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index 595c260..1e02a89 100644 --- a/hw/scsi/lsi53c895a.c +++ b/hw/scsi/lsi53c895a.c @@ -961,6 +961,10 @@ static void lsi_do_msgout(LSIState *s) DPRINTF("WDTR (ignored)\n"); lsi_skip_msgbytes(s, 1); break; + case 4: + DPRINTF("PPR (ignored)\n"); + lsi_skip_msgbytes(s, 5); + break; default: goto bad; } -- 1.8.3.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message 2017-12-11 16:45 ` George Kennedy @ 2017-12-11 16:55 ` Paolo Bonzini 2017-12-11 17:11 ` George Kennedy 0 siblings, 1 reply; 5+ messages in thread From: Paolo Bonzini @ 2017-12-11 16:55 UTC (permalink / raw) To: George Kennedy, qemu-devel; +Cc: qemu-trivial On 11/12/2017 17:45, George Kennedy wrote: > The LSI 53c895a code does not handle the PPR Extended Message. Add > support to handle PPR Extended Message like SDTR and WDTR are handled. > That is, to skip past the message bytes and ignore the message. > > --- > hw/scsi/lsi53c895a.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c > index 595c260..1e02a89 100644 > --- a/hw/scsi/lsi53c895a.c > +++ b/hw/scsi/lsi53c895a.c > @@ -961,6 +961,10 @@ static void lsi_do_msgout(LSIState *s) > DPRINTF("WDTR (ignored)\n"); > lsi_skip_msgbytes(s, 1); > break; > + case 4: > + DPRINTF("PPR (ignored)\n"); > + lsi_skip_msgbytes(s, 5); > + break; > default: > goto bad; > } Hi George, for a patch to QEMU to be accepted, you need to confirm the origin of your patch (according to the "Developer Certificate of Origin", see https://developercertificate.org/). In order to do this, it's enough to reply to this message with "Signed-off-by: George Kennedy <george.kennedy@oracle.com>" in the reply. Thanks, Paolo ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message 2017-12-11 16:55 ` Paolo Bonzini @ 2017-12-11 17:11 ` George Kennedy 2018-08-17 17:26 ` Paolo Bonzini 0 siblings, 1 reply; 5+ messages in thread From: George Kennedy @ 2017-12-11 17:11 UTC (permalink / raw) To: Paolo Bonzini, qemu-devel; +Cc: qemu-trivial Thank you Paolo, "Signed-off-by: George Kennedy<george.kennedy@oracle.com>" George On 12/11/2017 11:55 AM, Paolo Bonzini wrote: > On 11/12/2017 17:45, George Kennedy wrote: >> The LSI 53c895a code does not handle the PPR Extended Message. Add >> support to handle PPR Extended Message like SDTR and WDTR are handled. >> That is, to skip past the message bytes and ignore the message. >> >> --- >> hw/scsi/lsi53c895a.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c >> index 595c260..1e02a89 100644 >> --- a/hw/scsi/lsi53c895a.c >> +++ b/hw/scsi/lsi53c895a.c >> @@ -961,6 +961,10 @@ static void lsi_do_msgout(LSIState *s) >> DPRINTF("WDTR (ignored)\n"); >> lsi_skip_msgbytes(s, 1); >> break; >> + case 4: >> + DPRINTF("PPR (ignored)\n"); >> + lsi_skip_msgbytes(s, 5); >> + break; >> default: >> goto bad; >> } > Hi George, > > for a patch to QEMU to be accepted, you need to confirm the origin of > your patch (according to the "Developer Certificate of Origin", see > https://developercertificate.org/). > > In order to do this, it's enough to reply to this message with > "Signed-off-by: George Kennedy <george.kennedy@oracle.com>" in the reply. > > Thanks, > > Paolo ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message 2017-12-11 17:11 ` George Kennedy @ 2018-08-17 17:26 ` Paolo Bonzini 0 siblings, 0 replies; 5+ messages in thread From: Paolo Bonzini @ 2018-08-17 17:26 UTC (permalink / raw) To: George Kennedy, qemu-devel; +Cc: qemu-trivial On 11/12/2017 18:11, George Kennedy wrote: > "Signed-off-by: George Kennedy <george.kennedy@oracle.com>" Queued, thanks. Better late than never. Paolo ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-08-17 17:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1511980051-20457-2-git-send-email-george.kennedy@oracle.com>
2017-12-07 15:25 ` [Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message George Kennedy
2017-12-11 16:45 ` George Kennedy
2017-12-11 16:55 ` Paolo Bonzini
2017-12-11 17:11 ` George Kennedy
2018-08-17 17:26 ` Paolo Bonzini
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).