From: Richard Henderson <richard.henderson@linaro.org>
To: Danila Zhebryakov <d.zhebryakov@yandex.ru>, qemu-devel@nongnu.org
Cc: Chinmay Rath <rathc@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
Riku Voipio <riku.voipio@iki.fi>,
Ilya Leoshkevich <iii@linux.ibm.com>,
qemu-ppc@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
David Hildenbrand <david@redhat.com>,
qemu-s390x@nongnu.org, Laurent Vivier <laurent@vivier.eu>,
Thomas Huth <thuth@redhat.com>
Subject: Re: [PATCH 1/3] accel/tcg: Unify big- and little- endian atomic ops
Date: Fri, 22 Aug 2025 19:24:30 +1000 [thread overview]
Message-ID: <35a78a36-989e-425a-b99e-bda52da8d20c@linaro.org> (raw)
In-Reply-To: <20250821113348.91339-2-d.zhebryakov@yandex.ru>
On 8/21/25 21:33, Danila Zhebryakov wrote:
> @@ -1894,6 +1894,14 @@ static void *atomic_mmu_lookup(CPUState *cpu, vaddr addr, MemOpIdx oi,
> notdirty_write(cpu, addr, size, full, retaddr);
> }
>
> + if (unlikely(tlb_addr & TLB_BSWAP)) {
> + assert(!( ( full->slow_flags[MMU_DATA_STORE]
> + ^ full->slow_flags[MMU_DATA_LOAD ])
> + & TLB_BSWAP));
> +
> + *need_bswap = !need_bswap;
> + }
> +
How is this supposed to work?
(!) TLB_BSWAP is a slow-flags bit, so it will never be set in tlb_addr.
(2) Both MMU_DATA_STORE and MMU_DATA_LOAD will have the same value for TLB_BSWAP: X ^ X ==
0, so sure, that assert can't fire.
r~
next prev parent reply other threads:[~2025-08-22 9:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 11:33 [PATCH 0/3] Add support for PowerPC e500 little-endian pages Danila Zhebryakov
2025-08-21 11:33 ` [PATCH 1/3] accel/tcg: Unify big- and little- endian atomic ops Danila Zhebryakov
2025-08-22 9:24 ` Richard Henderson [this message]
2025-08-22 9:26 ` Richard Henderson
2025-08-25 0:58 ` Richard Henderson
2025-08-21 11:33 ` [PATCH 2/3] target/ppc: Add support for LE pages on PowerPC booke206 mmu Danila Zhebryakov
2025-08-25 1:06 ` Richard Henderson
2025-08-21 11:33 ` [PATCH 3/3] target/ppc: fix GDB stub to work correctly with LE pages Danila Zhebryakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35a78a36-989e-425a-b99e-bda52da8d20c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=d.zhebryakov@yandex.ru \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=laurent@vivier.eu \
--cc=npiggin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rathc@linux.ibm.com \
--cc=riku.voipio@iki.fi \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).