From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 26CEBC4332F for ; Fri, 30 Dec 2022 07:08:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pB9Ut-0005ZM-AH; Fri, 30 Dec 2022 02:08:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pB9Uo-0005Xl-5Z for qemu-devel@nongnu.org; Fri, 30 Dec 2022 02:08:02 -0500 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pB9Um-0007hS-CA for qemu-devel@nongnu.org; Fri, 30 Dec 2022 02:08:01 -0500 Received: by mail-wm1-x333.google.com with SMTP id fm16-20020a05600c0c1000b003d96fb976efso12602930wmb.3 for ; Thu, 29 Dec 2022 23:07:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/etFgTGUsqILty+ksbzAMhlux2U86WAmtzBthdTIKWU=; b=cggPulInhfEQKrRgPXoIKy0+t/OYzPYRGsBj0CQ2hdLFoO3oQaye6UOTME+auiEwwY 3YWZdqJlu/lsi19BeuC2udjUTG9VbWwBLCRGYgLkQ2IX7+rXy2X06Gl6cY13no16lt+M hkCXvX0U+dWUOojhAq934B2hKRqdEXSKzWYKHh56La7mq9PrYYVIGQsONMgQF0BbLGOL LpE0MVVea8hyZPc4ZE2j+Q2PsbEPsDlppBas5ITnNO5j6JJh+tG0Vm15YEbh4vqZOFFJ tBHnRCww/4erT3Ay+L1Ry+J52ORGpt0nY8Awq+jUIEgM8AiTakvWJjNbtSZTmWdz3rK2 ILgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/etFgTGUsqILty+ksbzAMhlux2U86WAmtzBthdTIKWU=; b=477Pr+erqwDRyCmZ7PhZEVlCUYFvtvIOGu9V3jUydIp8KgieUEcCvimy2yHcvL20Wk 8amNIdyTZMrjfQeIKiMVGVjWiiYFxykAuReFX61EkSwQ0ps6jaizvAVeTVGigIPcXzAv q86x2lD316l1dIgXteEJhVHNScCAB5hECnJyDG5AT4V688FKjAS+JhiomPWlZ+cw8nAQ F+FM75EMUlD6CIUNpQblawhz4BhHHPzTJ1Q8qUqTRyhmT4K4Gh2kwrMzJ6eeG0Zaivn0 hyVbFGrk7HKJRE9UZ90ZvKqtPL2DakTtw2TaDgxVW4kD0Zss4oQV49ST6vuEyGXLahkB 5iJA== X-Gm-Message-State: AFqh2kpfRHDU/lDcD7SjraeFFBDkl3a9LpFRSNZXbeu5heSMF7p9oGou cyDtFAR1XwpOrfvoxwQOCfeb7A== X-Google-Smtp-Source: AMrXdXs3Uy7nI6WRK6voVTWtHFDI0qgDftktYByJ0uD2YTFztqmf6SArUH5fZvgUDdt4PInMA7eeRQ== X-Received: by 2002:a05:600c:4f55:b0:3d3:5166:2da4 with SMTP id m21-20020a05600c4f5500b003d351662da4mr21766000wmq.8.1672384078503; Thu, 29 Dec 2022 23:07:58 -0800 (PST) Received: from [192.168.30.216] ([81.0.6.76]) by smtp.gmail.com with ESMTPSA id l27-20020a05600c1d1b00b003cfd4e6400csm29632521wms.19.2022.12.29.23.07.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Dec 2022 23:07:58 -0800 (PST) Message-ID: <35b39b89-f2e0-3c57-3ecb-825b6b98e890@linaro.org> Date: Fri, 30 Dec 2022 08:07:55 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 4/9] hw/arm/aspeed_ast10x0: Map I3C peripheral To: Peter Delevoryas Cc: qemu-devel@nongnu.org, Steven Lee , Peter Delevoryas , qemu-arm@nongnu.org, Cleber Rosa , Peter Maydell , Beraldo Leal , Wainer dos Santos Moschetta , Troy Lee , Andrew Jeffery , Joel Stanley , =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Peter Delevoryas , Jamin Lin References: <20221229152325.32041-1-philmd@linaro.org> <20221229152325.32041-5-philmd@linaro.org> Content-Language: en-US From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.149, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 29/12/22 21:46, Peter Delevoryas wrote: > On Thu, Dec 29, 2022 at 04:23:20PM +0100, Philippe Mathieu-Daudé wrote: >> Since I don't have access to the datasheet, the relevant >> values were found in: >> https://github.com/AspeedTech-BMC/zephyr/blob/v00.01.08/dts/arm/aspeed/ast10x0.dtsi >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/arm/aspeed_ast10x0.c | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> @@ -240,6 +244,18 @@ static void aspeed_soc_ast1030_realize(DeviceState *dev_soc, Error **errp) >> sysbus_connect_irq(SYS_BUS_DEVICE(&s->i2c.busses[i]), 0, irq); >> } >> >> + /* I3C */ >> + if (!sysbus_realize(SYS_BUS_DEVICE(&s->i3c), errp)) { >> + return; >> + } >> + aspeed_mmio_map(s, SYS_BUS_DEVICE(&s->i3c), 0, sc->memmap[ASPEED_DEV_I3C]); >> + for (i = 0; i < ASPEED_I3C_NR_DEVICES; i++) { >> + qemu_irq irq = qdev_get_gpio_in(DEVICE(&s->armv7m), >> + sc->irqmap[ASPEED_DEV_I3C] + i); >> + /* The AST1030 I2C controller has one IRQ per bus. */ > > Should this comment be I2C or I3C? Oops indeed, copy/paste leftover :) > Reviewed-by: Peter Delevoryas Thanks!