Re: [PATCH] MAINTAINERS: Name and email address change

[Hanna Reitz <hreitz@redhat.com>]

On 10.08.21 14:18, Philippe Mathieu-Daudé wrote:
> On 8/10/21 1:46 PM, Hanna Reitz wrote:
>> On 10.08.21 13:29, Philippe Mathieu-Daudé wrote:
>>> On 8/10/21 11:50 AM, Hanna Reitz wrote:
>>>> I have changed my name and email address.  Update the MAINTAINERS file
>>>> to match.
>>>>
>>>> Signed-off-by: Hanna Reitz <hreitz@redhat.com>
>>>> ---
>>>>    MAINTAINERS | 8 ++++----
>>>>    1 file changed, 4 insertions(+), 4 deletions(-)
>>> I'd recommend you to also add an entry in .mailmap:
>>>
>>> -- >8 --
>>> diff --git a/.mailmap b/.mailmap
>>> index 082ff893ab3..504839c84d3 100644
>>> --- a/.mailmap
>>> +++ b/.mailmap
>>> @@ -53,6 +53,7 @@ Anthony Liguori <anthony@codemonkey.ws> Anthony
>>> Liguori <aliguori@us.ibm.com>
>>>    Filip Bozuta <filip.bozuta@syrmia.com> <filip.bozuta@rt-rk.com.com>
>>>    Frederic Konrad <konrad@adacore.com> <fred.konrad@greensocs.com>
>>>    Greg Kurz <groug@kaod.org> <gkurz@linux.vnet.ibm.com>
>>> +Hanna Reitz <hreitz@redhat.com> <mreitz@redhat.com>
>>>    Huacai Chen <chenhuacai@kernel.org> <chenhc@lemote.com>
>>>    Huacai Chen <chenhuacai@kernel.org> <chenhuacai@loongson.cn>
>>>    James Hogan <jhogan@kernel.org> <james.hogan@imgtec.com>
>>> ---
>> Hu, I didn’t know there is such a thing.  Looks like I could even do
>>
>> Hanna Reitz <hreitz@redhat.com> Max Reitz <mreitz@redhat.com>
> If you want to restrict to 'Max Reitz', but without it it will simply
> take all mails from <mreitz@>. IMO KISS, no need to filter by name in
> your case :)

Oh, right.  I thought not giving the name would only replace the email 
address, for some reason.

>> Feels a bit like cheating, though...?
> No, why? The "preferred name forms" section seems adequate.

Well.  It’s not exactly a preferred name form, is it.

But it is a case of “git author config” change, so I suppose it fits best.

>>> As it or with .mailmap modified:
>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> What is nice with .mailmap is the combination with ./get_maintainers.pl,
> in particular when it defaults looking at commit history. If you
> Sob/Acked a commit as Max, the script (call by git-send-email) will
> replace it by Hanna.

That almost sounds like a reason not to do it.  You know, so I can deny 
any involvement on maintainer-less files. O:)

> For the contribution statistics, all your previous contributions as Max
> will be directly shown as Hanna (along with your future ones).

OK, well, if you insist. :)

Hanna