From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60589) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eQtRK-0008Ls-Ib for qemu-devel@nongnu.org; Mon, 18 Dec 2017 06:18:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eQtRH-0006vw-9Z for qemu-devel@nongnu.org; Mon, 18 Dec 2017 06:18:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37528) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eQtRH-0006vA-2W for qemu-devel@nongnu.org; Mon, 18 Dec 2017 06:18:31 -0500 References: <1513446109-9013-1-git-send-email-stefanb@linux.vnet.ibm.com> From: Thomas Huth Message-ID: <35bf84c9-271d-5ded-0876-0edb9304b2fc@redhat.com> Date: Mon, 18 Dec 2017 12:18:26 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL v1 00/32] Merge tpm 2017/12/15 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Stefan Berger Cc: QEMU Developers On 17.12.2017 22:34, Peter Maydell wrote: > On 16 December 2017 at 17:41, Stefan Berger wrote: >> The following patch series refactors the TPM TIS and backend drivers for >> easier addition of new front-end devices. Further, the TPM buffer sizes >> are read from the backend and the backend's buffer size can be adjusted >> by the frontend, if necessary. >> >> >> The following changes since commit 0ef0583d5adceb9138bdb47494dabd1549ac5b6d: >> >> Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20171214' into staging (2017-12-14 15:32:32 +0000) >> >> are available in the git repository at: >> >> git://github.com/stefanberger/qemu-tpm.git tags/pull-tpm-2017-12-15-1 >> >> for you to fetch changes up to 683c4b775355cc7acd301e8efe7d4c1c9acdafd8: >> >> tpm: tpm_passthrough: Fail startup if FE buffer size < BE buffer size (2017-12-14 23:39:15 -0500) >> >> ---------------------------------------------------------------- >> Merge tpm 2017/12/15 v1 > > Applied, thanks. This apparently broke compilation on non-x86 architectures: LINK s390x-softmmu/qemu-system-s390x ../hw/core/qdev-properties-system.o: In function `release_tpm': /home/thuth/devel/qemu/hw/core/qdev-properties-system.c:291: undefined reference to `tpm_backend_reset' ../hw/core/qdev-properties-system.o: In function `set_tpm': /home/thuth/devel/qemu/hw/core/qdev-properties-system.c:274: undefined reference to `qemu_find_tpm_be' /home/thuth/devel/qemu/hw/core/qdev-properties-system.c:278: undefined reference to `tpm_backend_init' collect2: error: ld returned 1 exit status make: Leaving directory `/home/thuth/s390x/qemu' make[1]: *** [qemu-system-s390x] Error 1 make: *** [subdir-s390x-softmmu] Error 2 Could you please fix this ASAP? Thomas