qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH] travis: remove TCI test
Date: Wed, 23 Sep 2020 18:31:34 +0200	[thread overview]
Message-ID: <35d0b042-4f18-65b4-7b59-34eb545012db@redhat.com> (raw)
In-Reply-To: <fe045d2d-022b-0a7e-8330-a2def315c16f@redhat.com>

On 23/09/2020 18.26, Paolo Bonzini wrote:
> On 23/09/20 18:04, Thomas Huth wrote:
>> On 23/09/2020 17.10, Paolo Bonzini wrote:
>>> The TCI test is already performed on gitlab CI, and it fails because
>>> Travis tests (generally) disable tools and therefore do not have
>>> "make check-qtest".  Just remove it.
>> Huh? Where is it failing? It currently seems to work fine:
>>
>>  https://travis-ci.org/github/qemu/qemu/jobs/729440748
>>
>> Anyway, since we already have similar job in the Gitlab-CI, I think it's
>> ok to remove it from Travis, so with the commit message tweaked:
>>
>> Acked-by: Thomas Huth <thuth@redhat.com>
>>
>>
> 
> You're right, it's only broken on my own branch (due to "meson: qtest:
> set "depends" correctly").  Currently we're running all qtests with a
> QTEST_QEMU_IMG pointing to a nonexistent executable, and I'd rather
> avoid that.  In that patch I took the big hammer, but we can also decide
> not to remove qtests for --disable-tools and add a little bit of
> complication to tests/qtest/meson.build.

I think there are only very few qtests that need one of the tools, so
I'd prefer if we could keep at least the ones enabled with
--disable-tools that do not require any of the tools.

 Thomas



      reply	other threads:[~2020-09-23 16:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23 15:10 [PATCH] travis: remove TCI test Paolo Bonzini
2020-09-23 16:04 ` Thomas Huth
2020-09-23 16:26   ` Paolo Bonzini
2020-09-23 16:31     ` Thomas Huth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35d0b042-4f18-65b4-7b59-34eb545012db@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).