* [PATCH] target/tricore/helper: Use correct string format in cpu_tlb_fill()
@ 2024-03-19 5:14 Philippe Mathieu-Daudé
2024-03-19 6:30 ` Philippe Mathieu-Daudé
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-03-19 5:14 UTC (permalink / raw)
To: qemu-devel
Cc: Richard Henderson, Bastian Koppelmann,
Philippe Mathieu-Daudé
'address' got converted from target_ulong to vaddr in commit
68d6eee73c ("target/tricore: Convert to CPUClass::tlb_fill").
Use the corresponding format string to avoid casting.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/tricore/helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/tricore/helper.c b/target/tricore/helper.c
index 6d9e80cc0c..76bd226370 100644
--- a/target/tricore/helper.c
+++ b/target/tricore/helper.c
@@ -76,9 +76,9 @@ bool tricore_cpu_tlb_fill(CPUState *cs, vaddr address, int size,
ret = get_physical_address(env, &physical, &prot,
address, rw, mmu_idx);
- qemu_log_mask(CPU_LOG_MMU, "%s address=" TARGET_FMT_lx " ret %d physical "
+ qemu_log_mask(CPU_LOG_MMU, "%s address=0x%" VADDR_PRIx " ret %d physical "
HWADDR_FMT_plx " prot %d\n",
- __func__, (target_ulong)address, ret, physical, prot);
+ __func__, address, ret, physical, prot);
if (ret == TLBRET_MATCH) {
tlb_set_page(cs, address & TARGET_PAGE_MASK,
--
2.41.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] target/tricore/helper: Use correct string format in cpu_tlb_fill()
2024-03-19 5:14 [PATCH] target/tricore/helper: Use correct string format in cpu_tlb_fill() Philippe Mathieu-Daudé
@ 2024-03-19 6:30 ` Philippe Mathieu-Daudé
2024-03-19 15:40 ` Richard Henderson
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-03-19 6:30 UTC (permalink / raw)
To: qemu-devel, Anton Johansson; +Cc: Richard Henderson, Bastian Koppelmann
+Anton
On 19/3/24 06:14, Philippe Mathieu-Daudé wrote:
> 'address' got converted from target_ulong to vaddr in commit
> 68d6eee73c ("target/tricore: Convert to CPUClass::tlb_fill").
> Use the corresponding format string to avoid casting.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/tricore/helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/tricore/helper.c b/target/tricore/helper.c
> index 6d9e80cc0c..76bd226370 100644
> --- a/target/tricore/helper.c
> +++ b/target/tricore/helper.c
> @@ -76,9 +76,9 @@ bool tricore_cpu_tlb_fill(CPUState *cs, vaddr address, int size,
> ret = get_physical_address(env, &physical, &prot,
> address, rw, mmu_idx);
>
> - qemu_log_mask(CPU_LOG_MMU, "%s address=" TARGET_FMT_lx " ret %d physical "
> + qemu_log_mask(CPU_LOG_MMU, "%s address=0x%" VADDR_PRIx " ret %d physical "
> HWADDR_FMT_plx " prot %d\n",
> - __func__, (target_ulong)address, ret, physical, prot);
> + __func__, address, ret, physical, prot);
>
> if (ret == TLBRET_MATCH) {
> tlb_set_page(cs, address & TARGET_PAGE_MASK,
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] target/tricore/helper: Use correct string format in cpu_tlb_fill()
2024-03-19 5:14 [PATCH] target/tricore/helper: Use correct string format in cpu_tlb_fill() Philippe Mathieu-Daudé
2024-03-19 6:30 ` Philippe Mathieu-Daudé
@ 2024-03-19 15:40 ` Richard Henderson
2024-03-24 9:43 ` Bastian Koppelmann
2024-03-26 9:58 ` Philippe Mathieu-Daudé
3 siblings, 0 replies; 5+ messages in thread
From: Richard Henderson @ 2024-03-19 15:40 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel; +Cc: Bastian Koppelmann
On 3/18/24 19:14, Philippe Mathieu-Daudé wrote:
> 'address' got converted from target_ulong to vaddr in commit
> 68d6eee73c ("target/tricore: Convert to CPUClass::tlb_fill").
> Use the corresponding format string to avoid casting.
>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> target/tricore/helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] target/tricore/helper: Use correct string format in cpu_tlb_fill()
2024-03-19 5:14 [PATCH] target/tricore/helper: Use correct string format in cpu_tlb_fill() Philippe Mathieu-Daudé
2024-03-19 6:30 ` Philippe Mathieu-Daudé
2024-03-19 15:40 ` Richard Henderson
@ 2024-03-24 9:43 ` Bastian Koppelmann
2024-03-26 9:58 ` Philippe Mathieu-Daudé
3 siblings, 0 replies; 5+ messages in thread
From: Bastian Koppelmann @ 2024-03-24 9:43 UTC (permalink / raw)
To: Philippe Mathieu-Daudé; +Cc: qemu-devel, Richard Henderson
On Tue, Mar 19, 2024 at 06:14:13AM +0100, Philippe Mathieu-Daudé wrote:
> 'address' got converted from target_ulong to vaddr in commit
> 68d6eee73c ("target/tricore: Convert to CPUClass::tlb_fill").
> Use the corresponding format string to avoid casting.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/tricore/helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Cheers,
Bastian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] target/tricore/helper: Use correct string format in cpu_tlb_fill()
2024-03-19 5:14 [PATCH] target/tricore/helper: Use correct string format in cpu_tlb_fill() Philippe Mathieu-Daudé
` (2 preceding siblings ...)
2024-03-24 9:43 ` Bastian Koppelmann
@ 2024-03-26 9:58 ` Philippe Mathieu-Daudé
3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-03-26 9:58 UTC (permalink / raw)
To: qemu-devel; +Cc: Richard Henderson, Bastian Koppelmann
On 19/3/24 06:14, Philippe Mathieu-Daudé wrote:
> 'address' got converted from target_ulong to vaddr in commit
> 68d6eee73c ("target/tricore: Convert to CPUClass::tlb_fill").
> Use the corresponding format string to avoid casting.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> target/tricore/helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Thanks, patch queued.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-03-26 9:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-19 5:14 [PATCH] target/tricore/helper: Use correct string format in cpu_tlb_fill() Philippe Mathieu-Daudé
2024-03-19 6:30 ` Philippe Mathieu-Daudé
2024-03-19 15:40 ` Richard Henderson
2024-03-24 9:43 ` Bastian Koppelmann
2024-03-26 9:58 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).