From: Richard Henderson <rth@twiddle.net>
To: Michael Rolnik <mrolnik@gmail.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH v10 09/10] target-avr: updating translate.c to use instructions translation
Date: Wed, 13 Jul 2016 00:21:50 -0700 [thread overview]
Message-ID: <35ec363c-303e-431c-4648-e19a0f3578ce@twiddle.net> (raw)
In-Reply-To: <CAK4993gevKUX55gyrbOcQGtrqLagYKqexAyn+fEse_ix1wCyqg@mail.gmail.com>
On 07/12/2016 08:49 PM, Michael Rolnik wrote:
> if I fold this patch into previous ones, they will become non buildable,
> because this patch assumes existance of functions from the preceding patch.
> Is this acceptable?
All patches need to be buildable, so that git bisect works.
The previous patches are already (sort of) non-buildable, but you don't notice
because you've not added translate-inst.o to obj-y until here. But there's
certainly no reason to put code in translate.c in one patch, then move it to
translate.h in another.
r~
next prev parent reply other threads:[~2016-07-13 7:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 22:33 [Qemu-devel] [PATCH v10 00/10] *** 8bit AVR cores *** Michael Rolnik
2016-07-06 22:33 ` [Qemu-devel] [PATCH v10 01/10] target-avr: AVR cores support is added Michael Rolnik
2016-07-12 17:19 ` Richard Henderson
2016-07-13 3:32 ` Michael Rolnik
2016-07-13 7:17 ` Richard Henderson
2016-07-13 10:54 ` Michael Rolnik
2016-07-13 12:35 ` Michael Rolnik
2016-07-13 15:27 ` Richard Henderson
2016-07-06 22:33 ` [Qemu-devel] [PATCH v10 02/10] target-avr: adding AVR CPU features/flavors Michael Rolnik
2016-07-06 22:33 ` [Qemu-devel] [PATCH v10 03/10] target-avr: adding a sample AVR board Michael Rolnik
2016-07-06 22:33 ` [Qemu-devel] [PATCH v10 04/10] target-avr: adding instructions encodings Michael Rolnik
2016-07-06 22:33 ` [Qemu-devel] [PATCH v10 05/10] target-avr: adding AVR interrupt handling Michael Rolnik
2016-07-06 22:33 ` [Qemu-devel] [PATCH v10 06/10] target-avr: adding helpers for IN, OUT, SLEEP, WBR & unsupported instructions Michael Rolnik
2016-07-12 17:22 ` Richard Henderson
2016-07-06 22:33 ` [Qemu-devel] [PATCH v10 07/10] target-avr: adding instruction decoder Michael Rolnik
2016-07-06 22:33 ` [Qemu-devel] [PATCH v10 08/10] target-avr: adding instruction translation Michael Rolnik
2016-07-12 17:29 ` Richard Henderson
2016-07-06 22:33 ` [Qemu-devel] [PATCH v10 09/10] target-avr: updating translate.c to use instructions translation Michael Rolnik
2016-07-12 17:30 ` Richard Henderson
2016-07-13 3:49 ` Michael Rolnik
2016-07-13 7:21 ` Richard Henderson [this message]
2016-07-19 14:22 ` Michael Rolnik
2016-07-06 22:33 ` [Qemu-devel] [PATCH v10 10/10] target-avr: instruction decoder generator Michael Rolnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35ec363c-303e-431c-4648-e19a0f3578ce@twiddle.net \
--to=rth@twiddle.net \
--cc=mrolnik@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).