From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNEUX-0005YL-4X for qemu-devel@nongnu.org; Wed, 13 Jul 2016 03:21:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bNEUS-0000nl-UB for qemu-devel@nongnu.org; Wed, 13 Jul 2016 03:21:56 -0400 Received: from mail-pa0-x243.google.com ([2607:f8b0:400e:c03::243]:34840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bNEUS-0000nh-Mw for qemu-devel@nongnu.org; Wed, 13 Jul 2016 03:21:52 -0400 Received: by mail-pa0-x243.google.com with SMTP id dx3so2530874pab.2 for ; Wed, 13 Jul 2016 00:21:52 -0700 (PDT) Sender: Richard Henderson References: <1467844395-28900-1-git-send-email-mrolnik@gmail.com> <1467844395-28900-10-git-send-email-mrolnik@gmail.com> From: Richard Henderson Message-ID: <35ec363c-303e-431c-4648-e19a0f3578ce@twiddle.net> Date: Wed, 13 Jul 2016 00:21:50 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v10 09/10] target-avr: updating translate.c to use instructions translation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Rolnik Cc: QEMU Developers , Peter Maydell On 07/12/2016 08:49 PM, Michael Rolnik wrote: > if I fold this patch into previous ones, they will become non buildable, > because this patch assumes existance of functions from the preceding patch. > Is this acceptable? All patches need to be buildable, so that git bisect works. The previous patches are already (sort of) non-buildable, but you don't notice because you've not added translate-inst.o to obj-y until here. But there's certainly no reason to put code in translate.c in one patch, then move it to translate.h in another. r~