Re: [PATCH v2 39/42] audio: cleanup, use bool for booleans

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 22/10/25 08:56, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Use slightly better types for the job.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>   audio/audio_int.h      | 12 ++++++------
>   audio/audio_template.h |  6 +++---
>   include/qemu/audio.h   |  8 ++++----
>   audio/audio.c          | 30 +++++++++++++++---------------
>   4 files changed, 28 insertions(+), 28 deletions(-)


> diff --git a/include/qemu/audio.h b/include/qemu/audio.h
> index 216b95eb4f..f5c32550dc 100644
> --- a/include/qemu/audio.h
> +++ b/include/qemu/audio.h
> @@ -98,8 +98,8 @@ SWVoiceOut *AUD_open_out (
>   void AUD_close_out (AudioBackend *be, SWVoiceOut *sw);
>   size_t AUD_write (SWVoiceOut *sw, void *pcm_buf, size_t size);
>   int  AUD_get_buffer_size_out (SWVoiceOut *sw);
> -void AUD_set_active_out (SWVoiceOut *sw, int on);
> -int  AUD_is_active_out (SWVoiceOut *sw);
> +void AUD_set_active_out (SWVoiceOut *sw, bool on);
> +bool AUD_is_active_out (SWVoiceOut *sw);
>   
>   void     AUD_init_time_stamp_out (SWVoiceOut *sw, QEMUAudioTimeStamp *ts);
>   uint64_t AUD_get_elapsed_usec_out (SWVoiceOut *sw, QEMUAudioTimeStamp *ts);
> @@ -128,8 +128,8 @@ SWVoiceIn *AUD_open_in (
>   
>   void AUD_close_in (AudioBackend *be, SWVoiceIn *sw);
>   size_t AUD_read (SWVoiceIn *sw, void *pcm_buf, size_t size);
> -void AUD_set_active_in (SWVoiceIn *sw, int on);
> -int  AUD_is_active_in (SWVoiceIn *sw);
> +void AUD_set_active_in (SWVoiceIn *sw, bool on);
> +bool AUD_is_active_in (SWVoiceIn *sw);
>   
>   void     AUD_init_time_stamp_in (SWVoiceIn *sw, QEMUAudioTimeStamp *ts);
>   uint64_t AUD_get_elapsed_usec_in (SWVoiceIn *sw, QEMUAudioTimeStamp *ts);
> diff --git a/audio/audio.c b/audio/audio.c
> index 5d3fb799f9..a9df7d73cd 100644
> --- a/audio/audio.c
> +++ b/audio/audio.c
> @@ -405,7 +405,7 @@ static void audio_notify_capture (CaptureVoiceOut *cap, audcnotification_e cmd)
>       }
>   }
>   
> -static void audio_capture_maybe_changed (CaptureVoiceOut *cap, int enabled)
> +static void audio_capture_maybe_changed (CaptureVoiceOut *cap, bool enabled)

Please fix checkpatch.pl errors while modifying these lines, otherwise:
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>