From: Laurent Vivier <laurent@vivier.eu>
To: Chuck Zmudzinski <brchuckz@aol.com>, qemu-devel@nongnu.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Anthony Perard <anthony.perard@citrix.com>,
Paul Durrant <paul@xen.org>,
xen-devel@lists.xenproject.org,
"qemu-trivial@nongnu.org" <qemu-trivial@nongnu.org>
Subject: Re: [PATCH v4 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations
Date: Wed, 2 Nov 2022 19:14:35 +0100 [thread overview]
Message-ID: <35fe81de-09f1-ff7f-e5e5-c738ab838d08@vivier.eu> (raw)
In-Reply-To: <5f1342a13c09af77b1a7b0aeaba5955bcea89731.1667242033.git.brchuckz@aol.com>
Le 31/10/2022 à 22:35, Chuck Zmudzinski a écrit :
> When Qemu is built with --enable-xen and --disable-xen-pci-passthrough
> and the target os is linux, the build fails with:
>
> meson.build:3477:2: ERROR: File xen_pt_stub.c does not exist.
>
> Fixes: 582ea95f5f93 ("meson: convert hw/xen")
>
> Signed-off-by: Chuck Zmudzinski <brchuckz@aol.com>
> ---
> v2: Remove From: <email address> tag at top of commit message
>
> v3: No change to this patch since v2
>
> v4: Use brchuckz@aol.com instead of brchuckz@netscape.net for the author's
> email address to match the address used by the same author in commits
> be9c61da and c0e86b76
>
> hw/xen/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/xen/meson.build b/hw/xen/meson.build
> index 08dc1f6857..ae0ace3046 100644
> --- a/hw/xen/meson.build
> +++ b/hw/xen/meson.build
> @@ -18,7 +18,7 @@ if have_xen_pci_passthrough
> 'xen_pt_msi.c',
> ))
> else
> - xen_specific_ss.add('xen_pt_stub.c')
> + xen_specific_ss.add(files('xen_pt_stub.c'))
> endif
>
> specific_ss.add_all(when: ['CONFIG_XEN', xen], if_true: xen_specific_ss)
Applied to my trivial-patches branch.
Thanks,
Laurent
next prev parent reply other threads:[~2022-11-02 18:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1667242033.git.brchuckz.ref@aol.com>
2022-10-31 21:35 ` [PATCH v4 0/2] xen/pt: fix FTBFS and reserve PCI slot 2 for the Intel IGD Chuck Zmudzinski
2022-10-31 21:35 ` [PATCH v4 1/2] xen/pt: fix syntax error that causes FTBFS in some configurations Chuck Zmudzinski
2022-10-31 22:08 ` Philippe Mathieu-Daudé
2022-11-02 18:14 ` Laurent Vivier [this message]
2022-10-31 21:35 ` [PATCH v4 2/2] xen/pt: reserve PCI slot 2 for Intel igd-passthru Chuck Zmudzinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35fe81de-09f1-ff7f-e5e5-c738ab838d08@vivier.eu \
--to=laurent@vivier.eu \
--cc=anthony.perard@citrix.com \
--cc=brchuckz@aol.com \
--cc=paul@xen.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).