From: "Philippe Mathieu-Daudé" <philippe.mathieu.daude@gmail.com>
To: Akihiko Odaki <akihiko.odaki@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH v3 2/2] ui/cocoa: Create menus in iothread
Date: Mon, 21 Mar 2022 23:00:03 +0100 [thread overview]
Message-ID: <35fee27e-186f-ad15-e3c7-526cbe66dd1e@gmail.com> (raw)
In-Reply-To: <20220321041043.24112-3-akihiko.odaki@gmail.com>
On 21/3/22 05:10, Akihiko Odaki wrote:
> Commit 0439c5a4623d674efa0c72abd62ca6e98bb7cf87 introduced an
> assertion that blk_all_next is called in the main thread. The function
> is called in the following chain:
> - blk_all_next
> - qmp_query_block
> - addRemovableDevicesMenuItems
> - main
>
> This change moves the menu creation to the iothread. This also changes
> the menu creation procedure to construct the entire menu tree before
> setting to NSApp, which is necessary because a menu set once cannot be
> modified if NSApp is already running.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com>
> ---
> ui/cocoa.m | 59 +++++++++++++++++++++---------------------------------
> 1 file changed, 23 insertions(+), 36 deletions(-)
Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
prev parent reply other threads:[~2022-03-21 22:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 4:10 [PATCH v3 0/2] Create menus in iothread Akihiko Odaki
2022-03-21 4:10 ` [PATCH v3 1/2] ui/cocoa: Move create_initial_menus Akihiko Odaki
2022-03-21 21:59 ` Philippe Mathieu-Daudé
2022-03-21 4:10 ` [PATCH v3 2/2] ui/cocoa: Create menus in iothread Akihiko Odaki
2022-03-21 22:00 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35fee27e-186f-ad15-e3c7-526cbe66dd1e@gmail.com \
--to=philippe.mathieu.daude@gmail.com \
--cc=akihiko.odaki@gmail.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).