From: "Andrew Jeffery" <andrew@aj.id.au>
To: "Cédric Le Goater" <clg@kaod.org>, "Peter Delevoryas" <pdel@fb.com>
Cc: irischenlj@fb.com,
"Philippe Mathieu-Daudé via" <qemu-arm@nongnu.org>,
"Cameron Esfahani via" <qemu-devel@nongnu.org>,
"Zev Weiss" <zev@bewilderbeest.net>,
openbmc@lists.ozlabs.org,
"Peter Maydell" <peter.maydell@linaro.org>,
"Joel Stanley" <joel@jms.id.au>,
"Jamin Lin" <jamin_lin@aspeedtech.com>
Subject: Re: [PATCH v2 0/5] hw: aspeed: Init all UART's with serial devices
Date: Mon, 16 May 2022 22:03:10 +0930 [thread overview]
Message-ID: <361f8b4a-9b98-4f20-a54e-0ccecf302cd4@www.fastmail.com> (raw)
In-Reply-To: <b978e205-66f7-e585-4cf0-6f3946fd1050@kaod.org>
On Mon, 16 May 2022, at 16:48, Cédric Le Goater wrote:
> On 5/16/22 08:23, Peter Delevoryas wrote:
>> v2:
>> - Rebased on Cedric's irq proposal. [1]
>> - Added "Introduce common UART init function" patch
>> - Added "Add uarts_num SoC attribute" patch
>> - Rewrote last commit's message for clarity
>
> Looks good to me.
>
>> I tried testing this by running acceptance tests, particularly the
>> boot_linux_console.py file, but I had to disable the raspi2_initrd case.
>> It's not related to my changes (A/B tested and it fails on upstream/master
>> too), but thought I would mention that.>
>> I also manually tested several machines:
>>
>> AST2400: https://github.com/facebook/openbmc/releases/download/v2021.49.0/wedge100.mtd
>> AST2500: https://github.com/facebook/openbmc/releases/download/v2021.49.0/fby3.mtd
>> AST2600: https://github.com/facebook/openbmc/releases/download/v2021.49.0/fuji.mtd
>> AST1030: https://github.com/peterdelevoryas/OpenBIC/releases/download/oby35-cl-2022.13.01/Y35BCL.elf
>>
>> [1] https://lore.kernel.org/qemu-devel/20220516055620.2380197-1-clg@kaod.org/
> I have quite a few images which I run manually. OpenBMC is providing
> images, Aspeed also. Joel did a small tool for the IBM rainier :
>
> https://github.com/shenki/qemu-boot-test
>
> Having an automated framework for Aspeed machines pulling images
> from different places would be nice but we cannot put all under
> QEMU.
For what it's worth I run this as a smoke test before pushing updates to openbmc/qemu:
https://github.com/openbmc/openbmc-build-scripts/blob/master/scripts/test-qemu
Andrew
next prev parent reply other threads:[~2022-05-16 13:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 6:23 [PATCH v2 0/5] hw: aspeed: Init all UART's with serial devices Peter Delevoryas
2022-05-16 6:23 ` [PATCH v2 1/5] hw: aspeed: Add missing UART's Peter Delevoryas
2022-05-16 7:19 ` Cédric Le Goater
2022-05-16 6:23 ` [PATCH v2 2/5] hw: aspeed: Add uarts_num SoC attribute Peter Delevoryas
2022-05-16 7:20 ` Cédric Le Goater
2022-05-16 6:23 ` [PATCH v2 3/5] hw: aspeed: Ensure AST1030 respects uart-default Peter Delevoryas
2022-05-16 7:20 ` Cédric Le Goater
2022-05-16 6:23 ` [PATCH v2 4/5] hw: aspeed: Introduce common UART init function Peter Delevoryas
2022-05-16 7:20 ` Cédric Le Goater
2022-05-16 6:23 ` [PATCH v2 5/5] hw: aspeed: Init all UART's with serial devices Peter Delevoryas
2022-05-16 7:22 ` Cédric Le Goater
2022-05-16 7:18 ` [PATCH v2 0/5] " Cédric Le Goater
2022-05-16 12:33 ` Andrew Jeffery [this message]
2022-05-16 16:20 ` Peter Delevoryas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=361f8b4a-9b98-4f20-a54e-0ccecf302cd4@www.fastmail.com \
--to=andrew@aj.id.au \
--cc=clg@kaod.org \
--cc=irischenlj@fb.com \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=openbmc@lists.ozlabs.org \
--cc=pdel@fb.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).