From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Yuquan Wang <wangyuquan1236@phytium.com.cn>,
rad@semihalf.com, peter.maydell@linaro.org
Cc: quic_llindhol@quicinc.com, marcin.juszkiewicz@linaro.org,
chenbaozi@phytium.com.cn, qemu-arm@nongnu.org,
qemu-devel@nongnu.org
Subject: Re: [PATCH v1 1/1] hw/arm/sbsa-ref: use XHCI to replace EHCI
Date: Wed, 31 May 2023 15:30:00 +0200 [thread overview]
Message-ID: <364e5f10-693a-4e3d-0031-865ad4e79b67@linaro.org> (raw)
In-Reply-To: <20230531095845.365019-2-wangyuquan1236@phytium.com.cn>
Hi Yuquan,
On 31/5/23 11:58, Yuquan Wang wrote:
> The current sbsa-ref cannot use EHCI controller which is only
> able to do 32-bit DMA, since sbsa-ref doesn't have RAM below 4GB.
> Hence, this uses XHCI to provide a usb controller with 64-bit
> DMA capablity instead of EHCI.
>
> Signed-off-by: Yuquan Wang <wangyuquan1236@phytium.com.cn>
> Change-Id: I1376f8bbc0e25dcd9d8a22b6e061cb56b3486394
> ---
> hw/arm/sbsa-ref.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
> -static void create_ehci(const SBSAMachineState *sms)
> +static void create_xhci(const SBSAMachineState *sms)
> {
> - hwaddr base = sbsa_ref_memmap[SBSA_EHCI].base;
> - int irq = sbsa_ref_irqmap[SBSA_EHCI];
> + hwaddr base = sbsa_ref_memmap[SBSA_XHCI].base;
> + int irq = sbsa_ref_irqmap[SBSA_XHCI];
>
> - sysbus_create_simple("platform-ehci-usb", base
> + sysbus_create_simple("sysbus-xhci", base,
Please use the definition: TYPE_XHCI_SYSBUS.
> qdev_get_gpio_in(sms->gic, irq));
> }
prev parent reply other threads:[~2023-05-31 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 9:58 [PATCH v1 0/1] hw/arm/sbsa-ref: use XHCI to replace EHCI Yuquan Wang
2023-05-31 9:58 ` [PATCH v1 1/1] " Yuquan Wang
2023-05-31 13:30 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=364e5f10-693a-4e3d-0031-865ad4e79b67@linaro.org \
--to=philmd@linaro.org \
--cc=chenbaozi@phytium.com.cn \
--cc=marcin.juszkiewicz@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quic_llindhol@quicinc.com \
--cc=rad@semihalf.com \
--cc=wangyuquan1236@phytium.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).