Re: [Qemu-devel] [PATCH v2 5/5] iotests: Add test 197 for covering copy-on-read

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1674 bytes --]

On 10/05/2017 09:41 AM, Stefan Hajnoczi wrote:
> On Tue, Oct 03, 2017 at 08:43:47PM -0500, Eric Blake wrote:
>> Add a test for qcow2 copy-on-read behavior, including exposure
>> for the just-fixed bugs.
>>
>> The copy-on-read behavior is always to a qcow2 image, but the
>> test is careful to allow running with most image protocol/format
>> combos as the backing file being copied from (luks being the
>> exception, as it is harder to pass the right secret to all the
>> right places).  In fact, for './check nbd', this appears to be
>> the first time we've had a qcow2 image wrapping NBD, requiring
>> an additional line in _filter_img_create to match the similar
>> line in _filter_img_info.
>>
>> Invoking blkdebug to prove we don't write too much took some
>> effort to get working; and it requires that $TEST_WRAP (based
>> on $TEST_DIR) not be subject to word splitting.  We may decide
>> later to have the entire iotests suite use relative rather than
>> absolute names, to avoid problems inherited by the absolute
>> name of $PWD or $TEST_DIR, at which point the sanity check in
>> this commit could be simplified.
>>
>> Signed-off-by: Eric Blake <eblake@redhat.com>
>>

> 
> Aside from the 2GB request issue:

I'm wondering if it is easy enough to just capture the qemu-io output
into a temporary holding area, grep that for success or OOM, then skip
the test on OOM (for small machines) or log the success (for beefy
spots), so that at least the test will not hold up CI efforts on small
machines.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]