From: Richard Henderson <richard.henderson@linaro.org>
To: Michal Privoznik <mprivozn@redhat.com>, qemu-devel@nongnu.org
Cc: david@redhat.com, imammedo@redhat.com
Subject: Re: [PATCH 3/3] backends/hostmem: Round up memory size for qemu_madvise() and mbind()
Date: Tue, 28 May 2024 10:22:32 -0700 [thread overview]
Message-ID: <3669d189-ca2f-474b-ba65-06cb8f404bb9@linaro.org> (raw)
In-Reply-To: <bd03706d336e9be360dd53cf125c27fbeb26acf7.1716912651.git.mprivozn@redhat.com>
On 5/28/24 09:15, Michal Privoznik wrote:
> + sz = ROUND_UP(sz, qemu_ram_pagesize(backend->mr.ram_block));
Second argument is evaluated twice.
You probably don't want that to be a function call.
r~
prev parent reply other threads:[~2024-05-28 17:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 16:15 [PATCH 0/3] backends/hostmem: Round up memory size for qemu_madvise() and mbind() Michal Privoznik
2024-05-28 16:15 ` [PATCH 1/3] osdep: Make qemu_madvise() to set errno in all cases Michal Privoznik
2024-05-28 16:51 ` David Hildenbrand
2024-05-28 16:15 ` [PATCH 2/3] backends/hostmem: Warn on qemu_madvise() failures Michal Privoznik
2024-05-28 16:15 ` [PATCH 3/3] backends/hostmem: Round up memory size for qemu_madvise() and mbind() Michal Privoznik
2024-05-28 16:47 ` David Hildenbrand
2024-05-29 6:48 ` Michal Prívozník
2024-05-29 12:30 ` David Hildenbrand
2024-05-28 17:22 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3669d189-ca2f-474b-ba65-06cb8f404bb9@linaro.org \
--to=richard.henderson@linaro.org \
--cc=david@redhat.com \
--cc=imammedo@redhat.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).