From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c
Date: Fri, 13 Sep 2019 13:05:21 +0200 [thread overview]
Message-ID: <3669d4b7-a0af-60a4-e519-e4bcfb033460@redhat.com> (raw)
In-Reply-To: <20190912184607.3507-1-eblake@redhat.com>
On 9/12/19 8:46 PM, Eric Blake wrote:
> This file is version-controlled, and not generated from a .json file.
>
> Fixes: bf582c3461b
> Reported-by: Thomas Huth <thuth@redhat.com>
Good catch!
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
> .gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitignore b/.gitignore
> index e9bbc006d39e..7de868d1eab4 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -41,6 +41,7 @@
> /qapi/qapi-types-*.[ch]
> /qapi/qapi-types.[ch]
> /qapi/qapi-visit-*.[ch]
> +!/qapi/qapi-visit-core.c
> /qapi/qapi-visit.[ch]
> /qapi/qapi-doc.texi
> /qemu-doc.html
>
next prev parent reply other threads:[~2019-09-13 11:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-12 18:46 [Qemu-devel] [PATCH] build: Don't ignore qapi-visit-core.c Eric Blake
2019-09-13 6:25 ` Thomas Huth
2019-09-13 11:05 ` Philippe Mathieu-Daudé [this message]
2019-09-13 11:34 ` Eric Blake
2019-09-19 10:14 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3669d4b7-a0af-60a4-e519-e4bcfb033460@redhat.com \
--to=philmd@redhat.com \
--cc=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).