From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E7D9C433DF for ; Thu, 30 Jul 2020 05:28:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4494B20842 for ; Thu, 30 Jul 2020 05:28:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aS/7AFZ1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4494B20842 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k117Y-0000N8-F6 for qemu-devel@archiver.kernel.org; Thu, 30 Jul 2020 01:28:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k116q-0008OT-Er for qemu-devel@nongnu.org; Thu, 30 Jul 2020 01:28:04 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:42886 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k116o-00086B-9g for qemu-devel@nongnu.org; Thu, 30 Jul 2020 01:28:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596086879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HY6i5rtBtKqT1lfTlALq1/+bUURk82idIQv5QUIDAa8=; b=aS/7AFZ19P6vuv8mvdtCCM0H/NSvrKkZnmGJD6tjb1f7Q7Fk0xByDGgzU6L56BWdhG5wMW tDy7YE+AXbfh3WUacs0RNN1WVZpYpWwdrh1q9zlIRn09U/6dcuRExz9jypuzP52tlTr6lo SPJzl6nTuo4fsqbet6985RdmRN9ebT0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-8uUDW3_COq2emg6ACHPMMw-1; Thu, 30 Jul 2020 01:27:56 -0400 X-MC-Unique: 8uUDW3_COq2emg6ACHPMMw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CEF5B1005504; Thu, 30 Jul 2020 05:27:54 +0000 (UTC) Received: from [10.72.13.179] (ovpn-13-179.pek2.redhat.com [10.72.13.179]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B1C019D9E; Thu, 30 Jul 2020 05:27:52 +0000 (UTC) Subject: Re: [PATCH 1/2] hw/net/net_tx_pkt: add function to check pkt->max_raw_frags To: Mauro Matteo Cascella References: <20200727170838.1101775-1-mcascell@redhat.com> <20200727170838.1101775-2-mcascell@redhat.com> From: Jason Wang Message-ID: <3672bcc5-329f-0cc6-a505-e5b21a316a20@redhat.com> Date: Thu, 30 Jul 2020 13:27:51 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=jasowang@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/29 23:51:30 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dmitry Fleytman , QEMU Developers , ziming zhang Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2020/7/29 上午12:26, Mauro Matteo Cascella wrote: > On Tue, Jul 28, 2020 at 6:06 AM Jason Wang wrote: >> >> On 2020/7/28 上午1:08, Mauro Matteo Cascella wrote: >>> This patch introduces a new function in hw/net/net_tx_pkt.{c,h} to check the >>> current data fragment against the maximum number of data fragments. >> >> I wonder whether it's better to do the check in >> net_tx_pkt_add_raw_fragment() and fail there. > Given the assertion, I assumed the caller is responsible for the > check, but moving the check in net_tx_pkt_add_raw_fragment() totally > makes sense to me. Want to send a new version for this? > >> Btw, I find net_tx_pkt_add_raw_fragment() does not unmap dma when >> returning to true, is this a bug? > Isn't it unmapped in net_tx_pkt_reset()? Probably but see how it was used in e1000e, the net_tx_pkt_reset() is only called when eop is set. Is this a bug? Thanks > >> Thanks >> >> >>> Reported-by: Ziming Zhang >>> Signed-off-by: Mauro Matteo Cascella >>> --- >>> hw/net/net_tx_pkt.c | 5 +++++ >>> hw/net/net_tx_pkt.h | 8 ++++++++ >>> 2 files changed, 13 insertions(+) >>> >>> diff --git a/hw/net/net_tx_pkt.c b/hw/net/net_tx_pkt.c >>> index 9560e4a49e..d035618f2c 100644 >>> --- a/hw/net/net_tx_pkt.c >>> +++ b/hw/net/net_tx_pkt.c >>> @@ -400,6 +400,11 @@ bool net_tx_pkt_add_raw_fragment(struct NetTxPkt *pkt, hwaddr pa, >>> } >>> } >>> >>> +bool net_tx_pkt_exceed_max_fragments(struct NetTxPkt *pkt) >>> +{ >>> + return pkt->raw_frags >= pkt->max_raw_frags; >>> +} >>> + >>> bool net_tx_pkt_has_fragments(struct NetTxPkt *pkt) >>> { >>> return pkt->raw_frags > 0; >>> diff --git a/hw/net/net_tx_pkt.h b/hw/net/net_tx_pkt.h >>> index 4ec8bbe9bd..e2ee46ae03 100644 >>> --- a/hw/net/net_tx_pkt.h >>> +++ b/hw/net/net_tx_pkt.h >>> @@ -179,6 +179,14 @@ bool net_tx_pkt_send_loopback(struct NetTxPkt *pkt, NetClientState *nc); >>> */ >>> bool net_tx_pkt_parse(struct NetTxPkt *pkt); >>> >>> +/** >>> +* indicates if the current data fragment exceeds max_raw_frags >>> +* >>> +* @pkt: packet >>> +* >>> +*/ >>> +bool net_tx_pkt_exceed_max_fragments(struct NetTxPkt *pkt); >>> + >>> /** >>> * indicates if there are data fragments held by this packet object. >>> *